-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
retrofit files with ICU4X license header #326
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question of URL - is /blob/ expected part?
@nciric Yeah, it is, at least it works: https://github.com/unicode-org/icu4x/blob/master/LICENSE That's how Github creates links to files in the repo working tree. Go figure. It trips me up all the time. |
Can someone help explain the formatter errors? For some reason, adding in these header comments causes
|
Is it possible that it triggers a cache with an older rust? |
Good question, but it looks like we already removed caching, and have a note with the issue number for re-including caching at some point in the future. |
I pulled your branch and that's what it did for me:
is there a chance that this is the issue? |
f8fc7b6
Yep, removing that newline fixed the formatter check. The formatter check is happy. I now just need a rubber stamp. |
Applied to
*.rs
,*.toml
, and*.yml
files using the following commands, when run at the root of the project:cc @hsivonen
Closes #255 .