-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IncludeXmlCommentsFromInheritDocs is broken in Swashbuckle.AspNetCore 6.8.0 #38
Comments
Same issue on my side in this call of method
It's working with Swashbuckle 6.7.3, the question of course is, if it's a bug in that library or my bad understanding of the required setup. |
It's working in Swashbuckle 6.7.3 for me too, and same code in my app was working since at least 6.5.0 with the same version of |
I've reported this issue to Swashbuckle repo, to see if it's intended or not from their side domaindrivendev/Swashbuckle.AspNetCore#3081 |
Same for my side, it looks like the change will be needed in this extension project to be compatible with Swashbuckle 6.8.0 and above |
I've fixed it in the PR linked above, not ideal fix but it works. Got no reaction from the author so far. Also it looks like CI is broken, it searches for dll to build nupkg in wrong location. |
Given what @alser said and the last commit seemingly from 2 years ago, I have to ask... is this project even still active? Wondering if I should actually wait or just try to find some alternative. |
Indeed I didn't want to wait longer and unfortunately I had to remove the dependencies to this project in my solution. |
Yeah, I feel the same. I've used the code from this project in my project (with the fix from the PR above), refactored it, added nullability annotations and newer C# syntax, targeting .NET 6.0+ only (got rid of legacy stuff), corrected some typos, no other changes. It works fine with the newest Swashbuckle package. If anyone's interested, I can incorporate it back to the solution structure, push it to my fork, so that someone else can fork it, fix CI (or get a new one), do any other changes, publish new package and maintain it. And huge thanks to the authors of this library! 😊 It has lots of features the original Swashbuckle one should have out of the box imho |
@unchase We are kinda stuck here. Care to help us out? |
I apologize for being away for a long time. I uploaded a fix that should solve the problem. |
Call to
IncludeXmlCommentsFromInheritDocs
fails with the exception below.Same behavior if supplied
XPathDocument
:In
Swashbuckle.AspNetCore
sources methodIncludeXmlComments
results in calling to:which in turn does this:
therefore creating
FilterDescriptor
withArguments = null
.Method
IncludeXmlCommentsFromInheritDocs
in this repo starts with:expecting to see single argument of type
XPathDocument
, but throwing ANEThe text was updated successfully, but these errors were encountered: