Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pkg): handle bundledDependencies correctly #343

Merged
merged 4 commits into from Jan 19, 2024

Conversation

JounQin
Copy link
Member

@JounQin JounQin commented Jan 19, 2024

No description provided.

@JounQin JounQin added the bug Something isn't working label Jan 19, 2024
@JounQin JounQin self-assigned this Jan 19, 2024
Copy link

changeset-bot bot commented Jan 19, 2024

🦋 Changeset detected

Latest commit: 41e5f74

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
prettier-plugin-pkg Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codesandbox-ci bot commented Jan 19, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Jan 19, 2024

size-limit report 📦

Path Size
packages/autocorrect/lib/index.js 538 B (0%)
packages/pkg/lib/index.js 447 B (0%)
packages/sh/lib/index.js 2.13 KB (0%)
packages/sql/lib/index.js 2.51 KB (0%)

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2c3ebb3) 88.16% compared to head (41e5f74) 87.79%.

Files Patch % Lines
packages/pkg/src/rules/object.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #343      +/-   ##
==========================================
- Coverage   88.16%   87.79%   -0.38%     
==========================================
  Files          10       10              
  Lines         169      172       +3     
  Branches       46       48       +2     
==========================================
+ Hits          149      151       +2     
- Misses         19       20       +1     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JounQin JounQin merged commit cd94a16 into master Jan 19, 2024
24 of 26 checks passed
@JounQin JounQin deleted the fix/bundledDependencies branch January 19, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant