Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add .node-version and .nvmrc support #341

Merged
merged 5 commits into from
Jan 17, 2024

Conversation

JoshuaKGoldberg
Copy link
Contributor

Fixes #340.

Copy link

changeset-bot bot commented Jan 16, 2024

🦋 Changeset detected

Latest commit: 435825a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
prettier-plugin-sh Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codesandbox-ci bot commented Jan 16, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (80e1909) 88.16% compared to head (435825a) 88.16%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #341   +/-   ##
=======================================
  Coverage   88.16%   88.16%           
=======================================
  Files          10       10           
  Lines         169      169           
  Branches       46       46           
=======================================
  Hits          149      149           
  Misses         19       19           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JounQin JounQin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README need to be updated and describe the limitation, right?

scripts/languages.ts Outdated Show resolved Hide resolved
scripts/languages.ts Outdated Show resolved Hide resolved
Co-authored-by: JounQin <admin@1stg.me>
@JounQin JounQin changed the title feat: add .nvmrc support feat: add .node-version and .nvmrc support Jan 16, 2024
@JounQin JounQin merged commit 0009cf2 into un-ts:master Jan 17, 2024
17 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the nvmrc-support branch January 17, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prettier-plugin-sh: support .nvmrc files?
2 participants