Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sql-formatter dialect option #334

Merged
merged 11 commits into from Dec 17, 2023
Merged

feat: add sql-formatter dialect option #334

merged 11 commits into from Dec 17, 2023

Conversation

karlhorky
Copy link
Contributor

Closes #322

Copy link

changeset-bot bot commented Dec 16, 2023

🦋 Changeset detected

Latest commit: b920ac4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
prettier-plugin-sql Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codesandbox-ci bot commented Dec 16, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Dec 16, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (909e30a) 87.80% compared to head (b920ac4) 88.16%.

Files Patch % Lines
packages/sql/src/index.ts 85.71% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #334      +/-   ##
==========================================
+ Coverage   87.80%   88.16%   +0.36%     
==========================================
  Files          10       10              
  Lines         164      169       +5     
  Branches       44       46       +2     
==========================================
+ Hits          144      149       +5     
  Misses         19       19              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JounQin
Copy link
Member

JounQin commented Dec 17, 2023

Can you add a test case? LGTM beyond this.

@JounQin JounQin merged commit 372ea30 into un-ts:master Dec 17, 2023
15 of 17 checks passed
@karlhorky karlhorky deleted the add-sql-formatter-dialect-option branch December 17, 2023 10:44
@JounQin
Copy link
Member

JounQin commented Dec 17, 2023

Thanks for your contributions!

@karlhorky
Copy link
Contributor Author

Glad to help :) thanks for your guidance, and the review and merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prettier-plugin-sql: Allow dialect as alternative to language
2 participants