fix: handle inconsistent exports of JSOX #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 939828a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #333 +/- ##
==========================================
+ Coverage 87.73% 87.80% +0.07%
==========================================
Files 10 10
Lines 163 164 +1
Branches 43 44 +1
==========================================
+ Hits 143 144 +1
Misses 19 19
Partials 1 1 ☔ View full report in Codecov by Sentry. |
JounQin
requested changes
Dec 16, 2023
JounQin
requested changes
Dec 16, 2023
JounQin
approved these changes
Dec 16, 2023
JounQin
requested changes
Dec 16, 2023
JounQin
approved these changes
Dec 16, 2023
JounQin
requested changes
Dec 16, 2023
JounQin
approved these changes
Dec 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like JSOX will also be releasing a fix that will eventually remove the need for this. However in the mean time this PR fixes the issue
Fixes: #332
Caused by d3x0r/JSOX#13