Call rebindCallback on errors as well #9688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nul800sebastiaan
deleted the
v8/bugfix/9341-call-rebindcallback-on-error
branch
nul800sebastiaan
pushed a commit
that referenced
this pull request
Jan 20, 2021
(cherry picked from commit 6d712b0) # Conflicts: # src/Umbraco.Web.UI.Client/src/common/directives/components/content/edit.controller.js # src/Umbraco.Web.UI.Client/src/common/services/contenteditinghelper.service.js
nielslyngsoe
added
the
state/sprint-candidate
umbrabot
removed
state/sprint-candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9341
When new content is created and saved with errors, it's still begin saved and therefore it's not new anymore and future saves should be changes of this. Therefore it's important that ID, Key, and other identifiers of this new content are parsed on. This is done by the rebindCallback and therefor we should call it despite validation issues.
I do have concerns: we have several Property Editors that react when the Content Model is updated, I hope these will still work as intended, our test focus should be around this topic.
This item has been added to our backlog AB#10081