Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add library model for Files.isDirectory #913

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Conversation

msridhar
Copy link
Collaborator

The first parameter cannot be null.

Fixes #912

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3fc9b8a) 86.98% compared to head (1caf442) 87.08%.
Report is 9 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #913      +/-   ##
============================================
+ Coverage     86.98%   87.08%   +0.10%     
- Complexity     1959     1989      +30     
============================================
  Files            77       77              
  Lines          6330     6426      +96     
  Branches       1223     1244      +21     
============================================
+ Hits           5506     5596      +90     
- Misses          420      422       +2     
- Partials        404      408       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@yuxincs yuxincs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@msridhar msridhar enabled auto-merge (squash) February 16, 2024 23:37
@msridhar msridhar merged commit d1d1fbc into uber:master Feb 16, 2024
12 checks passed
@msridhar msridhar deleted the issue-912 branch February 16, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jdk Files false positive/wrong line
2 participants