Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add foojay-resolver-convention plugin #905

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Conversation

msridhar
Copy link
Collaborator

@msridhar msridhar commented Feb 2, 2024

See https://github.com/gradle/foojay-toolchains. With this plugin, if relevant toolchains are not present on the local machine (e.g., for JDK 8 or JDK 21), Gradle will automatically download an appropriate distribution and place it in the local Gradle cache. This plugin is officially supported by Gradle, so I think it's safe to add. Without this plugin, new contributors may run into issues running basic commands like ./gradlew compileJava since it requires multiple JDKs to be installed in order to succeed.

@msridhar msridhar requested a review from yuxincs February 2, 2024 16:49
@msridhar msridhar enabled auto-merge (squash) February 2, 2024 16:49
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (848b0b1) 86.98% compared to head (701dd3c) 86.98%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #905   +/-   ##
=========================================
  Coverage     86.98%   86.98%           
  Complexity     1959     1959           
=========================================
  Files            77       77           
  Lines          6330     6330           
  Branches       1223     1223           
=========================================
  Hits           5506     5506           
  Misses          420      420           
  Partials        404      404           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuxincs
Copy link
Collaborator

yuxincs commented Feb 2, 2024

quick question due to my unfamiliarity with these: would it mess with user's local java installations or is it project-specific and will be put in gradle's cache folder or somewhere?

@msridhar
Copy link
Collaborator Author

msridhar commented Feb 2, 2024

quick question due to my unfamiliarity with these: would it mess with user's local java installations or is it project-specific and will be put in gradle's cache folder or somewhere?

It will not mess with any local installations; the downloaded toolchain is placed in the Gradle cache. Also, if Gradle's toolchain auto-detection finds a local installation of the right version of the JDK, nothing gets downloaded.

Copy link
Collaborator

@yuxincs yuxincs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@msridhar msridhar merged commit 3fc9b8a into uber:master Feb 2, 2024
12 checks passed
@msridhar msridhar deleted the add-foojay branch February 2, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants