Fix crash with raw types in overrides in JSpecify mode #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msridhar
added
the
jspecify
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #899 +/- ##
============================================
+ Coverage 86.96% 86.99% +0.02%
- Complexity 1956 1958 +2
============================================
Files 77 77
Lines 6320 6319 -1
Branches 1224 1223 -1
============================================
+ Hits 5496 5497 +1
+ Misses 419 418 -1
+ Partials 405 404 -1 ☔ View full report in Codecov by Sentry. |
akulk022
added a commit
to akulk022/NullAway
that referenced
this pull request
Jan 30, 2024
)" This reverts commit 091ac38
akulk022
pushed a commit
to akulk022/NullAway
that referenced
this pull request
Jan 30, 2024
We should skip checking for errors here instead of crashing (cherry picked from commit 091ac38)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should skip checking for errors here instead of crashing