Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade to Checker Framework 3.40.0 #895

Merged
merged 3 commits into from
Jan 14, 2024
Merged

Conversation

msridhar
Copy link
Collaborator

@msridhar msridhar commented Jan 13, 2024

This fixes a regression where we were seeing a crash in CFG construction. Reported upstream as typetools/checker-framework#6396.

Copy link

codecov bot commented Jan 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9ff44a7) 86.95% compared to head (65498bd) 86.95%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #895   +/-   ##
=========================================
  Coverage     86.95%   86.95%           
  Complexity     1953     1953           
=========================================
  Files            77       77           
  Lines          6315     6315           
  Branches       1222     1222           
=========================================
  Hits           5491     5491           
  Misses          420      420           
  Partials        404      404           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msridhar msridhar marked this pull request as ready for review January 13, 2024 23:10
@msridhar
Copy link
Collaborator Author

/benchmark

@msridhar msridhar requested a review from yuxincs January 13, 2024 23:10
Copy link

Main Branch:

Benchmark                          Mode  Cnt   Score   Error  Units
AutodisposeBenchmark.compile      thrpt   25   9.215 ± 0.070  ops/s
CaffeineBenchmark.compile         thrpt   25   2.108 ± 0.008  ops/s
DFlowMicroBenchmark.compile       thrpt   25  24.998 ± 0.419  ops/s
NullawayReleaseBenchmark.compile  thrpt   25   1.289 ± 0.016  ops/s

With This PR:

Benchmark                          Mode  Cnt   Score   Error  Units
AutodisposeBenchmark.compile      thrpt   25   9.336 ± 0.062  ops/s
CaffeineBenchmark.compile         thrpt   25   2.151 ± 0.020  ops/s
DFlowMicroBenchmark.compile       thrpt   25  25.081 ± 0.299  ops/s
NullawayReleaseBenchmark.compile  thrpt   25   1.295 ± 0.019  ops/s

Copy link
Collaborator

@yuxincs yuxincs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find and really appreciate the extra test case! Hopefully upstream can fix this soon.

@msridhar msridhar enabled auto-merge (squash) January 14, 2024 02:08
@msridhar msridhar merged commit c7007fd into master Jan 14, 2024
12 checks passed
@msridhar msridhar deleted the fix-symbol-completion-failure branch January 14, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants