Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Spring Framework 6.2 @MockitoBean, @MockitoSpyBean fields #1147

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

commonquail
Copy link
Contributor

Spring Framework 6.2 introduced two annotations, @MockitoBean and @MockitoSpyBean, that supersede Spring Boot's @MockBean and @SpyBean. Add these annotations to the field ignore list.

Spring Framework 6.2 introduced two annotations, `@MockitoBean` and
`@MockitoSpyBean`, that supersede Spring Boot's `@MockBean` and
`@SpyBean`. Add these annotations to the field ignore list.
@CLAassistant
Copy link

CLAassistant commented Feb 18, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@msridhar msridhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@msridhar msridhar enabled auto-merge (squash) February 18, 2025 22:14
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.12%. Comparing base (6f4cda7) to head (84f050d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1147   +/-   ##
=========================================
  Coverage     88.12%   88.12%           
  Complexity     2265     2265           
=========================================
  Files            86       86           
  Lines          7427     7427           
  Branches       1483     1483           
=========================================
  Hits           6545     6545           
  Misses          445      445           
  Partials        437      437           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msridhar msridhar merged commit 4805b0b into uber:master Feb 18, 2025
12 checks passed
@commonquail commonquail deleted the sf-mockitobean branch February 21, 2025 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants