Handle calls to generic constructors in JSpecify mode #1141
+39
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msridhar
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1141 +/- ##
============================================
- Coverage 88.24% 88.24% -0.01%
- Complexity 2261 2263 +2
============================================
Files 85 85
Lines 7309 7314 +5
Branches 1458 1458
============================================
+ Hits 6450 6454 +4
- Misses 431 432 +1
Partials 428 428 ☔ View full report in Codecov by Sentry. |
| break; | ||
| default: | ||
| throw new RuntimeException("Unexpected tree kind: " + tree.getKind()); | ||
| } | ||
| if (typeArguments.isEmpty()) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Below on line 178 don't you again need to handle the case where the tree.getKind() could be a NEW_CLASS?
There was a problem hiding this comment.
Good catch! Will fix
There was a problem hiding this comment.
Now have new tests that exercise the rest of the method for the NEW_CLASS case
|
@akshayutture this is ready for another look |
akshayutture
approved these changes
Feb 3, 2025
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1138