Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Test with Go 1.22 #1409

Merged
merged 2 commits into from Feb 7, 2024
Merged

ci: Test with Go 1.22 #1409

merged 2 commits into from Feb 7, 2024

Conversation

arukiidou
Copy link
Contributor

@arukiidou arukiidou commented Feb 3, 2024

With the release of Go 1.22,
CI should run against Go 1.21 and 1.22

@BorzdeG
Copy link

BorzdeG commented Feb 3, 2024

Maybe add something like ">=1.22.0-rc.2"? Then any latest version will be tested

Copy link

codecov bot commented Feb 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (27b96e3) 98.42% compared to head (969941b) 98.44%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1409      +/-   ##
==========================================
+ Coverage   98.42%   98.44%   +0.01%     
==========================================
  Files          53       53              
  Lines        3495     3527      +32     
==========================================
+ Hits         3440     3472      +32     
  Misses         46       46              
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arukiidou
Copy link
Contributor Author

Maybe add something like ">=1.22.0-rc.2"? Then any latest version will be tested

Once Go1.22 is GA, will change to 1.22.x.

@abhinav
Copy link
Collaborator

abhinav commented Feb 4, 2024

Thanks for the PR, @arukiidou!
I don't expect that RC version will be merged, but I'm glad we can confirm that Zap still works as-is against 1.22.
Once 1.22 is released, we can upgrade this PR to test against 1.22 proper and merge that.

@arukiidou arukiidou changed the title ci: Test with Go 1.22(still RC) ci: Test with Go 1.22(draft, still RC) Feb 4, 2024
@BorzdeG
Copy link

BorzdeG commented Feb 4, 2024

I use such a matrix to check the work in the beta version, but not blocking the work of CI

    strategy:
      matrix:
        go: ["1.20.x", "1.21.x"]
        continueOnError: [false]
        include:
          - go: ">=1.22.0-rc.1"
            continueOnError: true

@arukiidou
Copy link
Contributor Author

passed in Go1.22

@arukiidou arukiidou marked this pull request as ready for review February 7, 2024 10:06
@arukiidou
Copy link
Contributor Author

arukiidou commented Feb 7, 2024

Should these also bump to Go1.21?

zap/go.mod

Line 3 in 7db06bc

go 1.19

go 1.19

Copy link
Contributor

@sywhang sywhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Should these also be Go1.21 bumped?

I don't think these changes should occur in this PR - we can bump it to Go 1.20 to be safe, since starting from Go 1.21 the go module version is the minimum required version for the project to work as expected which isn't the case. That can be a separate discussion, though.

@arukiidou
Copy link
Contributor Author

Thank you!
Okay, now this pr is completed.

@arukiidou arukiidou changed the title ci: Test with Go 1.22(draft, still RC) ci: Test with Go 1.22 Feb 7, 2024
@JacobOaks JacobOaks merged commit e5745d6 into uber-go:master Feb 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants