Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve slog coverage #1347

Merged
merged 1 commit into from Sep 6, 2023

Conversation

zekth
Copy link
Contributor

@zekth zekth commented Sep 4, 2023

Improving test coverage on slog package

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #1347 (4594380) into master (b900128) will increase coverage by 0.35%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1347      +/-   ##
==========================================
+ Coverage   97.58%   97.93%   +0.35%     
==========================================
  Files          52       52              
  Lines        3392     3392              
==========================================
+ Hits         3310     3322      +12     
+ Misses         71       59      -12     
  Partials       11       11              

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@abhinav abhinav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thank you!

@abhinav abhinav merged commit 9a36792 into uber-go:master Sep 6, 2023
6 checks passed
@zekth zekth deleted the test/improve-slog-coverage branch September 6, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants