Add direct coverage to zap.Any #1309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1309 +/- ##
=======================================
Coverage 98.08% 98.08%
=======================================
Files 50 50
Lines 3242 3242
=======================================
Hits 3180 3180
Misses 53 53
Partials 9 9 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
abhinav
approved these changes
Jul 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Practically, the cases added are today covered by the tests for strongly typed functions, but are missing if someone was to do a refactoring like #1305 or #1307.
More theoretically, since
zap.Anyis an external interface, IMO it makes sense to test it separately too.