Introduce Str + Strs generic string helpers #1281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements uber-go#1275 by adding new `zapfield.Str` and `zapfield.Strs` types, which operate on generic string-like types and use the underlying `zap.String` and `zap.Strings` codepaths. In uber-go#1275, the decision was to put these in a separate `zap/exp/zapfield` package and I didn't see an existing one, so I made a new `zapfield` package.
Codecov Report
@@ Coverage Diff @@
## master #1281 +/- ##
==========================================
+ Coverage 97.93% 98.08% +0.15%
==========================================
Files 50 50
Lines 3240 3240
==========================================
+ Hits 3173 3178 +5
+ Misses 57 53 -4
+ Partials 10 9 -1 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sywhang
approved these changes
May 3, 2023
sywhang
pushed a commit
that referenced
this pull request
May 8, 2023
This is just a small nit from #1281 - I think the expected and got fields of the test case structs are flipped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #1275 by adding new
zapfield.Strandzapfield.Strstypes, which operate on generic string-like types and use the underlyingzap.Stringandzap.Stringscodepaths.In #1275, the decision was to put these in a separate
zap/exp/zapfieldpackage and I didn't see an existing one, so I made a newzapfieldpackage.Since this is a separate package, I had to copy a few test + non-test helpers here. If that's undesirable, I can export them in a shared helper package somewhere and have both places use that