New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This is rate shaping, not limiting #118

Open

chmike opened this issue Nov 25, 2023 · 1 comment

chmike commented Nov 25, 2023 •

edited

A rate limiter drops requests arriving at a rate exceeding a limit.

A rate shaper slows down processing rate to avoid exceeding the desired maximum rate. As it doesn't drop requests, there is a risk of queue overflow.

The optimal choice between the two depends on the type of application and the desired kind of protection.

EDIT: A combination of the two would probably be better.

Contributor

rabbbit commented Mar 4, 2024

Well it's a bit too late to rename the package. I agree we could add a note on traffic shaping if you'd like to put up a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment