Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Go 1.21 #1111

Merged
merged 6 commits into from
Aug 15, 2023
Merged

Use Go 1.21 #1111

merged 6 commits into from
Aug 15, 2023

Conversation

sywhang
Copy link
Contributor

@sywhang sywhang commented Aug 15, 2023

This updates go.mod files to use Go 1.21.

It also updates the CI to use Go 1.20 and 1.21 to test.

Note that this specifies the minimum version required to work with Fx to be Go 1.20 as specified in the toolchain specification (https://go.dev/doc/toolchain).

This updates go.mod files to use Go 1.21.

It also updates the CI to use Go 1.20 and 1.21 to test.

Note that this specifies the minimum version required to work with
Fx to be Go 1.20 as specified in the toolchain specification
(https://go.dev/doc/toolchain).
@sywhang sywhang requested a review from JacobOaks August 15, 2023 18:44
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #1111 (722cb69) into master (3ed9d86) will increase coverage by 0.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1111      +/-   ##
==========================================
+ Coverage   98.57%   98.80%   +0.22%     
==========================================
  Files          39       36       -3     
  Lines        3095     3088       -7     
==========================================
  Hits         3051     3051              
+ Misses         37       30       -7     
  Partials        7        7              

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sywhang sywhang merged commit 391edcd into uber-go:master Aug 15, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants