Add support for getting info from Invoke statements #383
+148
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #383 +/- ##
==========================================
+ Coverage 98.35% 98.36% +0.01%
==========================================
Files 21 21
Lines 1458 1471 +13
==========================================
+ Hits 1434 1447 +13
Misses 15 15
Partials 9 9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sywhang
reviewed
Apr 15, 2023
abhinav
reviewed
Apr 15, 2023
sywhang
reviewed
Apr 20, 2023
abhinav
reviewed
Apr 20, 2023
invoke.go
Outdated
| } | ||
|
|
||
| // FillInvokeInfo is an InvokeOption that writes info on the types requested | ||
| // by the Invoke function into the specified InvokeInfo. |
There was a problem hiding this comment.
nit: "accepted by the Invoke function"
tchung1118
approved these changes
Apr 24, 2023
alexisvisco
pushed a commit
to alexisvisco/dig
that referenced
this pull request
Aug 31, 2023
This commit exposes InvokeInfo and FillInvokeInfo to help users extract the types requested by an Invoke statement.
Example usage -
var info InvokeInfo
c.Invoke(func(typ1 type1, typ2 type2){}, FillInvokeInfo(&info))
// Will print the types requested by the Invoke statement
for _, typ := range info.ReqTypes {
fmt.Println(typ)
}
Refs: GO-669
|
@JacobOaks just to say that I have added outputs in the invoke information #395 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit exposes
InvokeInfoandFillInvokeInfoto help users extract the types requested by an Invoke statement.Example usage -
Refs: GO-669