hooks work but the git commit command doesn't commit

[martiliones]

Minimal Reproduction:

# Cloning test repository
$ git clone https://github.com/martiliones/husky-bug
$ cd husky-bug

# Installing husky
$ npm i

# Making changes into the test project
$ echo "some changes" > newfile.txt
$ git add .

# Commiting the changes and confirming hooks are working
$ git commit -m "some changes"
git hooks are running

# The command above didn't commit anything
$ git push origin master
Everything up-to-date

[vanduong185]

I got same issue

[vanduong185]

I did downgrade to v8.0.3 then It worked fine.

[cilly-yllic]

I did HOSKY=0 git commit -m 'comment'. It will skip git hook commands, but allows commits, so I think I'll use this workaround until it is fixed.

[remarkablemark]

I am also getting the error where I run git commit but the Vim editor does not show up

[recallwei]

I face the same problem.

[IronGeek]

Having the same issues.

I think it fails because the exit code in husky.sh is literally hardcoded to 1

husky/husky.sh

Lines 15 to 20 in 513c2c9

	sh -e "$s" "$@"
	c=$?
	[ $c != 0 ] && echo "husky - $h script failed (code $c)"
	[ $c = 127 ] && echo "husky - command not found in PATH=$PATH"
	exit 1

Souldn't it be exit $c instead?

---

Update:

I edited my local .husky/_/h file and the changed the last line to exit $c. It seems the git commit command works again.

[ $c != 0 ] && echo "husky - $h script failed (code $c)"
[ $c = 127 ] && echo "husky - command not found in PATH=$PATH"
- exit 1
+ exit $c

[lunoob]

The same problem appears when using it with release-it

[talhaibnmahmud]

Having the same issues.

I think it fails because the exit code in husky.sh is literally hardcoded to 1

husky/husky.sh

Lines 15 to 20 in 513c2c9

	sh -e "$s" "$@"
	c=$?
	[ $c != 0 ] && echo "husky - $h script failed (code $c)"
	[ $c = 127 ] && echo "husky - command not found in PATH=$PATH"
	exit 1

Souldn't it be exit $c instead?

Update:

I edited my local .husky/_/h file and the changed the last line to exit $c. It seems the git commit command works again.

[ $c != 0 ] && echo "husky - $h script failed (code $c)"
[ $c = 127 ] && echo "husky - command not found in PATH=$PATH"
- exit 1
+ exit $c

This fixed the issue for me too. This should be fixed with the new release ASAP

[gergelypap]

Fix available at #1336

Thanks @IronGeek for spotting it out!

[ffMathy]

Great work on getting it fixed! Husky is fully operational now ❤️