Symbol$CompletionFailure crash when building CFG

[msridhar]

To reproduce clone the following repo:

https://github.com/msridhar/cf-cfg-crash-example

Then run ./gradlew compileJava. I see (with CF 3.42.0):

> Task :lib:compileJava FAILED
error: SourceChecker.typeProcess: unexpected Throwable (CompletionFailure) while processing /Users/msridhar/git-repos/cf-cfg-crash-example/lib/src/main/java/net/sridharan/cfgcrash/Library.java; message: class file for org.apache.spark.sql.SparkSession$1 not found
  ; The Checker Framework crashed.  Please report the crash.  Version: Checker Framework 3.42.0.
  Compilation unit: /Users/msridhar/git-repos/cf-cfg-crash-example/lib/src/main/java/net/sridharan/cfgcrash/Library.java
  Last visited tree at line 8 column 1:
  public class Library {
  Exception: com.sun.tools.javac.code.Symbol$CompletionFailure: class file for org.apache.spark.sql.SparkSession$1 not found; com.sun.tools.javac.code.Symbol$CompletionFailure: class file for org.apache.spark.sql.SparkSession$1 not found
1 error

I see the same crash with CF 3.41.0 but not with 3.40.0. The class org.apache.spark.sql.SparkSession$1 does not exist in the library org.apache.spark:spark-sql_2.12:3.3.2. I couldn't convince Gradle / javac to print a full stack trace here, sorry. We can work around this issue in NullAway by downgrading to Checker Framework 3.40.0.

When debugging the same crash in NullAway I found that it occurs during phase 1 of CFG construction for this method. I wonder if this has to do with the new try-with-resources desugaring; will take a look.