Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client: fix UploadedFile and UploadedFiles decorators returning undefined #1103

Conversation

haaijman-imagem
Copy link
Contributor

@haaijman-imagem haaijman-imagem commented Apr 11, 2023

...when using the koa driver. The koa-multer 2.x or higher middleware remove the ctx.req.file property and move it to ctx.request.file and ctx.file. This is true for ctx.req.files as well.

Description

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors

Fixes

fixes #1012

@haaijman-imagem haaijman-imagem marked this pull request as ready for review April 11, 2023 08:07
@attilaorosz
Copy link
Member

Thanks for the fix!

@attilaorosz attilaorosz merged commit 9bcbe99 into typestack:develop Apr 11, 2023
5 checks passed
@haaijman-imagem haaijman-imagem deleted the fix-UploadedFile-returns-undefined-value branch April 12, 2023 06:28
@mrdavidrees
Copy link

@attilaorosz
Any indication of when this will be released on NPM?
currently holding me back from upgrading Koa

@attilaorosz
Copy link
Member

@mrdavidrees I will create a release today

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

fix: UploadedFile returns undefined value
3 participants