Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo: Build failure on main: explicit-function-return-type in createProjectService.ts #8963

Closed
JoshuaKGoldberg opened this issue Apr 21, 2024 · 2 comments · Fixed by #8966
Closed
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@JoshuaKGoldberg
Copy link
Member

Suggestion

Example from https://cloud.nx.app/runs/Bmb57hhYDR?utm_source=pull-request&utm_medium=comment:

/home/runner/work/typescript-eslint/typescript-eslint/packages/typescript-estree/src/create-program/createProjectService.ts
  51:7  error  Missing return type on function  @typescript-eslint/explicit-function-return-type
  52:7  error  Missing return type on function  @typescript-eslint/explicit-function-return-type
  54:7  error  Missing return type on function  @typescript-eslint/explicit-function-return-type

Was there some merge oddity from #8809?

@JoshuaKGoldberg JoshuaKGoldberg added triage Waiting for maintainers to take a look repo maintenance things to do with maintenance of the repo, and not with code/docs labels Apr 21, 2024
@JoshuaKGoldberg
Copy link
Member Author

cc @auvred @kirkwaiblinger @yeonjuan - #8809 had a passing build on merge, but looks like there's something borked here. Do any of you have time to look into this? 🙏

@auvred auvred added the accepting prs Go ahead, send a pull request that resolves this issue label Apr 22, 2024
@auvred auvred removed the triage Waiting for maintainers to take a look label Apr 22, 2024
@auvred
Copy link
Member

auvred commented Apr 22, 2024

It looks like typescript-estree lint results were taken from the cache: https://cloud.nx.app/runs/LO236EMoxL/task/typescript-estree%3Alint (Perhaps it was the wrong cache?)

Here is the fix: #8966

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants