Bug: [prefer-nullish-coalescing] <internal error when linting on binary expression (||) with destruct tuple and object with rename property>

[sasurau4]

Before You File a Bug Report Please Confirm You Have Done The Following...

• I have tried restarting my IDE and the issue persists.
• I have updated to the latest version of the packages.
• I have searched for related issues and found none that matched my issue.
• I have read the FAQ and my problem is not listed.

Playground Link

https://typescript-eslint.io/play/#ts=5.3.3&fileType=.tsx&code=PTAEEkDNQTwewK6gMZwLZoKYDsAuoBLbUSOAGzLgHciBzUOAJ1AEMATNu0AAxYGcUcbH1zdQuOKEaZcCRsQBuLMgkwNopOABpQAQQqEBAeQDSAWABQIcTAAOagGJxJAXlABtAEbOymFth0Ab1BKdjoALlBvcj9iAF8AXQBuS2tIBGxkXAIhEmcACgBKSKdJQNSwUCkZOWJ3SGU%2BTCCQuDDsWkiGsibQRIq%2By0t0zOzczSLQcosq6Vl5D26moNDODq7GzH6LOKGLVGF8D08WRhW2tc7WRNA3CcK9g5Eo25JNyyf8ZFelzA%2BhZ6rLhuFigAA%2BYJeEJQSSAA&eslintrc=N4KABGBEBOCuA2BTAzpAXGUEKQAIBcBPABxQGNoBLY-AWhXkoDt8B6Y6RAM0WlqYSNkAC1pkA9gEMkyMswDm6KL2jjokcGAC%2BILUA&tsconfig=N4KABGBEDGD2C2AHAlgGwKYCcDyiAuysAdgM6QBcYoEEkJemy0eFYDAruuGAL4g9A&tokens=false

Repro Code

// If you comment in following or adding `as const` to return value of foo, All is OK
// type Foo = [boolean, { loading: boolean }];
// function foo(): Foo {
//   return [false, { loading: false }]
// }

function foo() {
  return [false, {loading: false}]
}

const  [bar, {loading: a}] = foo()

const b = false
const c = false
const loading = a || b || c;

ESLint Config

module.exports = {
  "rules": {
    "@typescript-eslint/prefer-nullish-coalescing": "error"
  }
}

tsconfig

{
  "compilerOptions": {
    "strict": true
  }
}

Expected Result

No lint and internal errors

Actual Result

Following internal error happened

TypeError: Cannot read properties of undefined (reading 'some')
Occurred while linting /input.tsx:15
Rule: "@typescript-eslint/prefer-nullish-coalescing"
    at LogicalExpression[operator = "||"] (https://typescript-eslint.io/sandbox/index.js:143:58720)

Additional Info

No response

[auvred]

The problem is that it doesn't know what to do when type of left of LogicalExpression is any

Minimal repro: playground

Probably a bug. The rule shouldn't throw when it encounters any type

[GerroDen]

I have the same issue.
I tested it with the previous version 6.18.1 and it still runs.

[auvred]

The regression is caused by #8089. #8262 should fix it

[jschill]

It's also throwing in javascript-files (ie non-typescript files), where it's a little harder to correct the type.

[jasikpark]

I'm getting the same error when eslint tries to run the rule on one of my JS based eslint rule definitions in src/eslint-rules

webclient on  01-19-Upgrade_typescript-eslint [$] via  v18.16.0 took 5s 
❯ pnpm lint:js

> nebula-web@0.0.0 lint:js /Users/calebjasik/Git/defined.net/webclient
> eslint . --rulesdir ./eslint-rules --cache --cache-strategy content


Oops! Something went wrong! :(

ESLint: 8.56.0

TypeError: Cannot read properties of undefined (reading 'some')
Occurred while linting /Users/calebjasik/Git/defined.net/webclient/eslint-rules/jsx-no-target-blank.js:23
Rule: "@typescript-eslint/prefer-nullish-coalescing"
    at LogicalExpression[operator = "||"] (/Users/calebjasik/Git/defined.net/webclient/node_modules/.pnpm/@typescript-eslint+eslint-plugin@6.19.0_@typescript-eslint+parser@6.19.0_eslint@8.56.0_typescript@5.2.2/node_modules/@typescript-eslint/eslint-plugin/dist/rules/prefer-nullish-coalescing.js:267:32)
    at ruleErrorHandler (/Users/calebjasik/Git/defined.net/webclient/node_modules/.pnpm/eslint@8.56.0/node_modules/eslint/lib/linter/linter.js:1076:28)
    at /Users/calebjasik/Git/defined.net/webclient/node_modules/.pnpm/eslint@8.56.0/node_modules/eslint/lib/linter/safe-emitter.js:45:58
    at Array.forEach (<anonymous>)
    at Object.emit (/Users/calebjasik/Git/defined.net/webclient/node_modules/.pnpm/eslint@8.56.0/node_modules/eslint/lib/linter/safe-emitter.js:45:38)
    at NodeEventGenerator.applySelector (/Users/calebjasik/Git/defined.net/webclient/node_modules/.pnpm/eslint@8.56.0/node_modules/eslint/lib/linter/node-event-generator.js:297:26)
    at NodeEventGenerator.applySelectors (/Users/calebjasik/Git/defined.net/webclient/node_modules/.pnpm/eslint@8.56.0/node_modules/eslint/lib/linter/node-event-generator.js:326:22)
    at NodeEventGenerator.enterNode (/Users/calebjasik/Git/defined.net/webclient/node_modules/.pnpm/eslint@8.56.0/node_modules/eslint/lib/linter/node-event-generator.js:340:14)
    at CodePathAnalyzer.enterNode (/Users/calebjasik/Git/defined.net/webclient/node_modules/.pnpm/eslint@8.56.0/node_modules/eslint/lib/linter/code-path-analysis/code-path-analyzer.js:803:23)
    at /Users/calebjasik/Git/defined.net/webclient/node_modules/.pnpm/eslint@8.56.0/node_modules/eslint/lib/linter/linter.js:1111:32
 ELIFECYCLE  Command failed with exit code 2.