Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: [no-useless-template-literals] Add fixing suggestions #8056

Closed
4 tasks done
StyleShit opened this issue Dec 12, 2023 · 0 comments · Fixed by #8065
Closed
4 tasks done

Enhancement: [no-useless-template-literals] Add fixing suggestions #8056

StyleShit opened this issue Dec 12, 2023 · 0 comments · Fixed by #8065
Labels
accepting prs Go ahead, send a pull request that resolves this issue enhancement: plugin rule option New rule option for an existing eslint-plugin rule package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@StyleShit
Copy link
Contributor

Before You File a Proposal Please Confirm You Have Done The Following...

My proposal is suitable for this project

  • I believe my proposal would be useful to the broader TypeScript community (meaning it is not a niche proposal).

Link to the rule's documentation

https://typescript-eslint.io/rules/no-useless-template-literals

Description

Add suggestions to auto-fix the invalid cases

Splits from #7957

Fail

const a = `${ 1 }`;
const b = `${ null }`;
const c = `a-${ true }`;

Pass

const a = `1`;
const b = `null`;
const c = `a-true`;

Additional Info

No response
@StyleShit StyleShit added enhancement: plugin rule option New rule option for an existing eslint-plugin rule package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for maintainers to take a look labels Dec 12, 2023
@StyleShit StyleShit mentioned this issue Dec 12, 2023
Merged
@JoshuaKGoldberg JoshuaKGoldberg added accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for maintainers to take a look labels Dec 12, 2023
@StyleShit StyleShit mentioned this issue Dec 14, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue enhancement: plugin rule option New rule option for an existing eslint-plugin rule package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(eslint-plugin): [no-useless-template-literals] add fix suggestions StyleShit/typescript-eslint
2 participants
@JoshuaKGoldberg @StyleShit