feat(utils): update types to reflect RuleContext and SourceCode changes and deprecations

[G-Rath]

PR Checklist

• Addresses an existing open issue: fixes Enhancement: Update types for ESLint v9's changes and deprecations #7816
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

Reference: https://eslint.org/blog/2023/09/preparing-custom-rules-eslint-v9

[typescript-eslint]

Thanks for the PR, @G-Rath!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	d3bd6c3
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/655151c2d39d0f0009fbb413
😎 Deploy Preview	https://deploy-preview-7812--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 89 (🔴 down 10 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 527c3dd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 19 targets

• nx test type-utils --coverage=false
• nx test repo-tools --coverage=false
• nx run types:build
• nx test scope-manager --coverage=false
• nx run repo-tools:postinstall-script
• nx test typescript-estree --coverage=false
• nx test utils --coverage=false
• nx test visitor-keys --coverage=false
• nx test rule-schema-to-typescript-types --coverage=false
• nx test eslint-plugin-tslint --coverage=false
• nx test parser --coverage=false
• nx test ast-spec --coverage=false
• nx test eslint-plugin --coverage=false
• nx test eslint-plugin-internal --coverage=false
• nx run-many --target=lint --parallel
• nx run-many --target=typecheck --parallel
• nx run integration-tests:test
• nx run eslint-plugin:generate:configs
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint

---

Sent with 💌 from NxCloud.

[G-Rath]

Are folks ok if I ignore the deprecation linting errors? I can help getting them addressed but would prefer to do so in dedicated PR since they'll require actual runtime changes and there's a few different ways they can be approached

[JoshuaKGoldberg]

Well, we need typescript-eslint to work on both v8 and v9 for the time being. Dropping v8 would be a breaking change. I'd presume eslint-disable comments would be the way to go.

[G-Rath]

My point is you'll need to make changes to support v9 since some of these are being removed in that major - it's pretty straight forward (I've already done this in eslint-plugin-jest) but I'd still prefer to do it in a dedicated PR because there are two different changes here (adding types, moving off deprecated functions and properties) & how I've done it for eslint-plugin-jest might not be how you want to do it here

I'll add disable directives for now

[JoshuaKGoldberg]

Agreed. https://github.com/jest-community/eslint-plugin-jest/blob/3c12c9842df7950dd214855fa69b1785c4d1574d/src/rules/utils/misc.ts is roughly the strategy I'm betting we'll want to take. 🙂

export const getDeclaredVariables = (
  context: TSESLint.RuleContext<string, unknown[]>,
  node: TSESTree.Node,
) => {
  const sourceCode = getSourceCode(context);

  if ('getDeclaredVariables' in sourceCode) {
    return sourceCode.getDeclaredVariables(node);
  }

  return context.getDeclaredVariables(node);
};

[JoshuaKGoldberg]

💯 thanks!

[JoshuaKGoldberg]

Adding 1 approval label for now because this I'd love someone else from @typescript-eslint/triage-team to take a look at this area code. Both to raise visibility, and because I'm not 100% confident I'm not missing something. A gut hunch.

[JoshuaKGoldberg]

Thanks again @G-Rath!

[JoshuaKGoldberg]

Amusingly, there are now a bunch of lint failures on main: #7913. But this PR had a passing ✅. So nobody should feel bad 😄