Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rule-tester): fix parser fallback logic #7754

Conversation

rriski
Copy link
Contributor

@rriski rriski commented Oct 16, 2023

The docs at https://typescript-eslint.io/packages/rule-tester/#type-aware-testing show that for type-aware rule testing parserOptions needs to be specified. However, like shown in the docs, when parser is omitted then an error: "The first argument to require.resolve must be a string. Received null or undefined" is thrown due to a bug in parser fallback behavior.

PR Checklist

Overview

The docs at https://typescript-eslint.io/packages/rule-tester/#type-aware-testing
show that for type-aware rule testing `parserOptions` needs to be
specified. However, like shown in the docs, when `parser` is omitted
then an error: "The first argument to require.resolve must be a string.
Received null or undefined" is thrown due to a bug in `parser` fallback
behavior.
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @rriski!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Oct 16, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit e11c0b5
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/652cf8cad3b28800089fec6e
😎 Deploy Preview https://deploy-preview-7754--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 90 (🔴 down 6 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@rriski
Copy link
Contributor Author

rriski commented Oct 16, 2023

Another option is to fix the docs to include parser, let me know which one is preferred.

@bradzacher bradzacher added the bug Something isn't working label Oct 17, 2023
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

radical! thanks for fixing this!

@bradzacher bradzacher merged commit 34c23e0 into typescript-eslint:main Oct 17, 2023
47 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants