New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rule-tester): fix parser
fallback logic
#7754
fix(rule-tester): fix parser
fallback logic
#7754
Conversation
The docs at https://typescript-eslint.io/packages/rule-tester/#type-aware-testing show that for type-aware rule testing `parserOptions` needs to be specified. However, like shown in the docs, when `parser` is omitted then an error: "The first argument to require.resolve must be a string. Received null or undefined" is thrown due to a bug in `parser` fallback behavior.
Thanks for the PR, @rriski! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Another option is to fix the docs to include |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs at https://typescript-eslint.io/packages/rule-tester/#type-aware-testing show that for type-aware rule testing
parserOptions
needs to be specified. However, like shown in the docs, whenparser
is omitted then an error: "The first argument to require.resolve must be a string. Received null or undefined" is thrown due to a bug inparser
fallback behavior.PR Checklist
Overview