Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: [switch-exhaustiveness-check] Enum cases are not properly qualified #7747

Open
4 tasks done
somebody1234 opened this issue Oct 13, 2023 · 1 comment
Open
4 tasks done
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@somebody1234
Copy link

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have searched for related issues and found none that matched my issue.
  • I have read the FAQ and my problem is not listed.

Playground Link

https://typescript-eslint.io/play/#ts=4.9.3&showAST=es&fileType=.tsx&code=HYQwtgpgzgDiDGEAEBBJBvAUEpEAeMA9gE4AuuwArmEgEIbY5IDCANIzgCLs4C%2Bm-TABMI8ADYhiyeIWBRyIAFyoAdLUyYoAdwCWpeAAskAChABKBjnggoyFGpXNlWJkgBGUkAGtG-XkA&eslintrc=N4KABGBEBOCuA2BTAzpAXGUEKQAIBcBPABxQGNoBLY-AWhXkoDt8B6ZAd0vzIAt6AHrwCGsZPkoA3RExTJafRGQDW6KImjQA9tEjgwAXxAGgA&tsconfig=N4KABGBEDGD2C2AHAlgGwKYCcDyiAuysAdgM6QBcYoEEkJemy0eAcgK6qoDCAFutAGsylBm3TgwAXxCSgA&tokens=false

Repro Code

namespace A {
  export enum B {
    C,
    D,
  }
}

declare const a: A.B

switch (a) {
  case A.B.C: {
    break
  }
}

ESLint Config

{
  "rules": {
    "@typescript-eslint/switch-exhaustiveness-check": "error"
  }
}

tsconfig

No response

Expected Result

switch (a) {
  case A.B.C: {
    break
  }
  case A.B.D: { throw new Error('Not implemented yet: A.B.D case') }
}

Actual Result

switch (a) {
  case A.B.C: {
    break
  }
  case B.D: { throw new Error('Not implemented yet: B.D case') }
}

Additional Info

In the actual codebase, the enum is namespaced under an ESM import *, rather than a TypeScript namespace. However, I think both cases should be fixed by any potential PR that fixes this

@somebody1234 somebody1234 added bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for maintainers to take a look labels Oct 13, 2023
@JoshuaKGoldberg JoshuaKGoldberg added accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for maintainers to take a look labels Oct 19, 2023
@JoshuaKGoldberg
Copy link
Member

+1, both modules and namespaces should be supported.

Note that fixes/suggestions around adding in enums are a tricky thing to get right. #7691 has come across other difficulties with enum names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
2 participants