Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump supported TS version to 5.2 #7535

Merged
merged 2 commits into from Aug 25, 2023
Merged

feat: bump supported TS version to 5.2 #7535

merged 2 commits into from Aug 25, 2023

Conversation

bradzacher
Copy link
Member

PR Checklist

Overview

  • bump the version
  • regenerate lib types
  • regenerate playground types

@bradzacher bradzacher added dependencies Issue about dependencies of the package New TypeScript Version labels Aug 25, 2023
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Aug 25, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 7251239
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/64e7fca7df00050007239065
😎 Deploy Preview https://deploy-preview-7535--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud
Copy link

nx-cloud bot commented Aug 25, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7251239. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 40 targets

Sent with 💌 from NxCloud.

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #7535 (7251239) into main (c11e05c) will increase coverage by 2.11%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7535      +/-   ##
==========================================
+ Coverage   85.10%   87.22%   +2.11%     
==========================================
  Files         386      386              
  Lines       13383    13383              
  Branches     3955     3955              
==========================================
+ Hits        11390    11673     +283     
+ Misses       1614     1328     -286     
- Partials      379      382       +3     
Flag Coverage Δ
unittest 87.22% <100.00%> (+2.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ipt-estree/src/parseSettings/warnAboutTSVersion.ts 93.33% <100.00%> (ø)

... and 7 files with indirect coverage changes

console.error(e);
// eslint-disable-next-line no-process-exit
process.exit(1);
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's going on here? Is it related to #7534?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah so I ran the generator and noticed that it changed all of the lib files and caused a bunch of lint errors due to unsorted imports and such.

I figured that instead of manually running the linter afterwards was dumb cos we can automate it :)

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bradzacher bradzacher merged commit f18c88d into main Aug 25, 2023
52 checks passed
@bradzacher bradzacher deleted the ts-5-2-bump branch August 25, 2023 21:55
ChrisW-B pushed a commit to ChrisW-B/PersonalApi that referenced this pull request Aug 30, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`6.4.1` -> `6.5.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/6.4.1/6.5.0) |
| [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`6.4.1` -> `6.5.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/6.4.1/6.5.0) |
| [@typescript-eslint/typescript-estree](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`6.4.1` -> `6.5.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2ftypescript-estree/6.4.1/6.5.0) |
| [netlify-cli](https://github.com/netlify/cli) | devDependencies | minor | [`16.1.0` -> `16.2.0`](https://renovatebot.com/diffs/npm/netlify-cli/16.1.0/16.2.0) |

---

### Release Notes

<details>
<summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/eslint-plugin)</summary>

### [`v6.5.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#650-2023-08-28)

[Compare Source](typescript-eslint/typescript-eslint@v6.4.1...v6.5.0)

##### Bug Fixes

-   **eslint-plugin:** \[consistent-type-assertions] wrap object return value with parentheses ([#&#8203;6885](typescript-eslint/typescript-eslint#6885)) ([23ac499](typescript-eslint/typescript-eslint@23ac499))

You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

#### [6.4.1](typescript-eslint/typescript-eslint@v6.4.0...v6.4.1) (2023-08-21)

##### Bug Fixes

-   **eslint-plugin:** \[no-unnecessary-condition] false positives with branded types ([#&#8203;7466](typescript-eslint/typescript-eslint#7466)) ([b52658f](typescript-eslint/typescript-eslint@b52658f)), closes [#&#8203;7293](typescript-eslint/typescript-eslint#7293)

You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

</details>

<details>
<summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/parser)</summary>

### [`v6.5.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#650-2023-08-28)

[Compare Source](typescript-eslint/typescript-eslint@v6.4.1...v6.5.0)

**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)

You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

#### [6.4.1](typescript-eslint/typescript-eslint@v6.4.0...v6.4.1) (2023-08-21)

**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)

You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

</details>

<details>
<summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/typescript-estree)</summary>

### [`v6.5.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/typescript-estree/CHANGELOG.md#650-2023-08-28)

[Compare Source](typescript-eslint/typescript-eslint@v6.4.1...v6.5.0)

##### Features

-   bump supported TS version to 5.2 ([#&#8203;7535](typescript-eslint/typescript-eslint#7535)) ([f18c88d](typescript-eslint/typescript-eslint@f18c88d))
-   support Explicit Resource Management syntax for TS 5.2 ([#&#8203;7479](typescript-eslint/typescript-eslint#7479)) ([c11e05c](typescript-eslint/typescript-eslint@c11e05c))

You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

#### [6.4.1](typescript-eslint/typescript-eslint@v6.4.0...v6.4.1) (2023-08-21)

**Note:** Version bump only for package [@&#8203;typescript-eslint/typescript-estree](https://github.com/typescript-eslint/typescript-estree)

You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

</details>

<details>
<summary>netlify/cli (netlify-cli)</summary>

### [`v16.2.0`](https://github.com/netlify/cli/blob/HEAD/CHANGELOG.md#1620-2023-08-29)

[Compare Source](netlify/cli@v16.1.0...v16.2.0)

##### Features

-   add support for `context.params` in edge functions ([#&#8203;5964](netlify/cli#5964)) ([ed14e05](netlify/cli@ed14e05))
-   support custom function routes ([#&#8203;5954](netlify/cli#5954)) ([82b94b5](netlify/cli@82b94b5))

##### Bug Fixes

-   **deps:** update dependency [@&#8203;netlify/edge-bundler](https://github.com/netlify/edge-bundler) to v8.18.0 ([#&#8203;5953](netlify/cli#5953)) ([016cdf9](netlify/cli@016cdf9))
-   **deps:** update dependency [@&#8203;netlify/edge-bundler](https://github.com/netlify/edge-bundler) to v8.19.0 ([#&#8203;5971](netlify/cli#5971)) ([42478fd](netlify/cli@42478fd))
-   **deps:** update dependency [@&#8203;netlify/serverless-functions-api](https://github.com/netlify/serverless-functions-api) to v1.6.0 ([#&#8203;5935](netlify/cli#5935)) ([1d68354](netlify/cli@1d68354))
-   **deps:** update dependency [@&#8203;netlify/serverless-functions-api](https://github.com/netlify/serverless-functions-api) to v1.7.3 ([#&#8203;5957](netlify/cli#5957)) ([57d6627](netlify/cli@57d6627))
-   **deps:** update dependency lambda-local to v2.1.2 ([#&#8203;5967](netlify/cli#5967)) ([e592944](netlify/cli@e592944))
-   **deps:** update netlify packages ([#&#8203;5915](netlify/cli#5915)) ([1ad27ac](netlify/cli@1ad27ac))
-   **deps:** update netlify packages ([#&#8203;5965](netlify/cli#5965)) ([654c366](netlify/cli@654c366))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 3pm on Sunday" in timezone America/New_York, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi43NC4wIiwidXBkYXRlZEluVmVyIjoiMzYuNzQuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Reviewed-on: https://git.chriswb.dev/chrisw-b/PersonalApi/pulls/3
Reviewed-by: chrisw-b <chrisw-b@noreply.localhost>
Co-authored-by: Renovate Bot <renovate.bot@chrisb.xyz>
Co-committed-by: Renovate Bot <renovate.bot@chrisb.xyz>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2023
@@ -1,5 +1,6 @@
import type { TSESTree } from '@typescript-eslint/types';
import { AST_TOKEN_TYPES } from '@typescript-eslint/types';
import { ESLint } from '@typescript-eslint/utils/ts-eslint';
Copy link
Member

@armano2 armano2 Sep 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bradzacher this seem to be generating some issues on clean install

> yarn build

NX   Could not execute command because the task graph has a circular dependency
rule-schema-to-typescript-types:build --> type-utils:build --> utils:build --> scope-manager:build --> utils:build

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Issue about dependencies of the package New TypeScript Version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript 5.2 Support
3 participants