feat: update to lib types for TS 5.2 RC

[sosukesuzuki]

PR Checklist

• Addresses an existing open issue: RC support of TypeScript 5.2 Support #7155
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

Update TypeScript to 5.2.1-rc

[typescript-eslint]

Thanks for the PR, @sosukesuzuki!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	2db6ce1
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/64d8810036f2830008c6ddda
😎 Deploy Preview	https://deploy-preview-7451--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[codecov]

Codecov Report

Merging #7451 (2db6ce1) into main (c225b12) will decrease coverage by 2.10%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7451      +/-   ##
==========================================
- Coverage   87.34%   85.25%   -2.10%     
==========================================
  Files         381      386       +5     
  Lines       13336    13358      +22     
  Branches     3943     3943              
==========================================
- Hits        11648    11388     -260     
- Misses       1308     1593     +285     
+ Partials      380      377       -3     

Flag	Coverage Δ
unittest	85.25% <100.00%> (-2.10%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
packages/scope-manager/src/lib/decorators.ts	100.00% <ø> (ø)
packages/scope-manager/src/lib/dom.iterable.ts	100.00% <ø> (ø)
packages/scope-manager/src/lib/dom.ts	100.00% <ø> (ø)
packages/scope-manager/src/lib/es5.ts	100.00% <ø> (ø)
...ckages/scope-manager/src/lib/webworker.iterable.ts	100.00% <ø> (ø)
packages/scope-manager/src/lib/webworker.ts	100.00% <ø> (ø)
packages/typescript-estree/src/version-check.ts	100.00% <ø> (ø)
packages/scope-manager/src/lib/es2017.date.ts	100.00% <100.00%> (ø)
packages/scope-manager/src/lib/es2017.ts	100.00% <100.00%> (ø)
...ackages/scope-manager/src/lib/es2023.collection.ts	100.00% <100.00%> (ø)
... and 7 more

... and 7 files with indirect coverage changes

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2db6ce1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 37 targets

• nx test eslint-plugin --coverage=false
• Node 16 - nx test eslint-plugin --coverage=false
• Node 16 - nx test utils --coverage=false
• Node 16 - nx run types:build
• Node 20 - nx test eslint-plugin
• nx build website
• nx run-many --target=lint --parallel
• Node 20 - nx test typescript-estree
• nx test typescript-estree --coverage=false
• nx test eslint-plugin-internal --coverage=false
• Node 20 - nx test utils
• Node 20 - nx test scope-manager
• nx test eslint-plugin-tslint --coverage=false
• Node 20 - nx run types:build
• nx run types:build
• Node 20 - nx test repo-tools
• Node 20 - nx test visitor-keys
• Node 20 - nx test type-utils
• nx run-many --target=typecheck --parallel
• Node 20 - nx test rule-schema-to-typescript-types
• Node 20 - nx test parser
• nx run integration-tests:test
• Node 16 - nx test typescript-estree --coverage=false
• Node 16 - nx test type-utils --coverage=false
• Node 16 - nx test ast-spec --coverage=false
• Node 16 - nx test scope-manager --coverage=false
• Node 16 - nx test visitor-keys --coverage=false
• Node 16 - nx test eslint-plugin-internal --coverage=false
• Node 20 - nx test eslint-plugin-internal
• Node 20 - nx test eslint-plugin-tslint
• Node 20 - nx test ast-spec
• Node 16 - nx test parser --coverage=false
• Node 16 - nx test eslint-plugin-tslint --coverage=false
• Node 16 - nx test repo-tools --coverage=false
• Node 16 - nx test rule-schema-to-typescript-types --coverage=false
• nx run eslint-plugin:generate:configs
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint

---

Sent with 💌 from NxCloud.

[JoshuaKGoldberg]

...huh. Odd that 5.1 wasn't here before.

[JoshuaKGoldberg]

Why this change? Tests still work for me locally after reverting it.

[bradzacher]

But does it typecheck fine without it?
There's a new error in this version to ensure that things are configured correctly.

[JoshuaKGoldberg]

Yeah I like moving to the newer module & module resolution settings, just curious.

Also, per https://www.typescriptlang.org/tsconfig#moduleResolution, moduleResolution matches module by default with node16 and other newer targets.

[sosukesuzuki]

Without this change, a type error will occur.

[JoshuaKGoldberg]

Ah! https://devblogs.microsoft.com/typescript/announcing-typescript-5-2-rc/#module-and-moduleresolution-must-match-under-recent-node-js-settings

       tsconfig.spec.json:5:15 - error TS5110: Option 'module' must be set to 'Node16' when option 'moduleResolution' is set to 'Node16'.
       
       5     "module": "CommonJS",
                       ~~~~~~~~~~

Fun! In that case, I think we can get away with just the "module": "Node16":

Suggested change

"moduleResolution": "Node16"

[sosukesuzuki]

Thank you! e829631

[JoshuaKGoldberg]

LGTM, thanks! I'll defer to @bradzacher as more knowledgeable on TS upgrades.

Note for any onlookers: we'll still have to add support for using statements separately.

[bradzacher]

Thanks - step one is this! Step two is the new syntax.

[bradzacher]

next we can get to work on the syntax thanks heaps!