Bug: Typescript error in default value for new rule schema

[wespickett]

Before You File a Bug Report Please Confirm You Have Done The Following...

• I have tried restarting my IDE and the issue persists.
• I have updated to the latest version of the packages.
• I have searched for related issues and found none that matched my issue.
• I have read the FAQ and my problem is not listed.

Issue Description

In a new rule meta.schema an entry of, for example:

{
                type: 'object',
                properties: {
                  allowedTypeAnnotations: {
                    type: 'array',
                    items: { type: 'string' },
                    default: [],
                  },
                },
                additionalProperties: false,
 },

Gives an error for the default value of [], where I expect it to be a valid value
This is due to missing types for JSONSchema4Array and JSONSchema4Object in JSONSchema4Type.
Those types exist in json-schema: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/json-schema/index.d.ts#L30

PR with the fix:
#7406

Reproduction Repository Link

https://github.com/wespickett/typescript-eslint-ex1/tree/main

Repro Steps

1. clone the repo
2. npm install
3. Open in an editor like VSCode to see the error in example-rule.ts, or run npx tsc

Versions

package	version
@typescript-eslint/eslint-plugin	6.3.0
@typescript-eslint/parser	6.3.0
@typescript-eslint/scope-manager	6.3.0
@typescript-eslint/typescript-estree	6.3.0
@typescript-eslint/type-utils	6.3.0
@typescript-eslint/utils	6.3.0
TypeScript	5.1.6
ESLint	8.46.0
node	18.14.2

[wespickett]

@bradzacher Issue created as per your comment #7406 (comment)

[bradzacher]

Thanks for filing this!
With the examples I can see your intended code and why it's broken!

It's a rarer usecase to use default - a lot of codebases don't use it because (a) they don't know about it and (b) because its interaction with types or complex schemas can be somewhat confusing!

It's also not possible to enforce that the default defined in the schema is correctly defined to match the expected types.

We generally recommend that rules instead use defaultOptions to explicitly declare the options to use as you can enforce that the value passed there adheres to the options type you define for the rule, eg:

typescript-eslint/packages/eslint-plugin/src/rules/array-type.ts

Lines 132 to 136 in 0a1de14

	defaultOptions: [
	{
	default: 'array',
	},
	],

That being said - this is indeed a bug!

[JoshuaKGoldberg]

Coincidentally good timing: eslint/eslint#17448 discusses default options & schemas a bit.