fix(typescript-estree): support declare and export modifiers for nested namespace declaration

[sosukesuzuki]

PR Checklist

• Addresses an existing open issue: fixes Bug: typescript-estree does not support declare namespace foo.bar {} #7409
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

Support following syntax:

declare namespace foo.bar {}
export namespace foo.bar {}
export declare namespace foo.bar {}

[typescript-eslint]

Thanks for the PR, @sosukesuzuki!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	6bfd606
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/64d48bb2c131c70008845015
😎 Deploy Preview	https://deploy-preview-7410--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[sosukesuzuki]

I'm not sure if this is needed. It may be enough to check once at the top level?

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6bfd606. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 37 targets

• Node 20 - nx test typescript-estree
• nx build website
• Node 20 - nx test type-utils
• Node 20 - nx run types:build
• Node 16 - nx test utils --coverage=false
• Node 16 - nx run types:build
• Node 20 - nx test visitor-keys
• Node 20 - nx test eslint-plugin-internal
• Node 20 - nx test utils
• Node 20 - nx test ast-spec
• Node 20 - nx test repo-tools
• Node 20 - nx test scope-manager
• Node 20 - nx test rule-schema-to-typescript-types
• Node 16 - nx test visitor-keys --coverage=false
• Node 20 - nx test parser
• Node 20 - nx test eslint-plugin-tslint
• Node 20 - nx test eslint-plugin
• Node 16 - nx test typescript-estree --coverage=false
• nx run-many --target=typecheck --parallel
• nx test typescript-estree --coverage=false
• nx run integration-tests:test
• nx run types:build
• nx run-many --target=lint --parallel
• Node 16 - nx test repo-tools --coverage=false
• nx test eslint-plugin-tslint --coverage=false
• Node 16 - nx test eslint-plugin-tslint --coverage=false
• nx run eslint-plugin:generate:configs
• Node 16 - nx test parser --coverage=false
• Node 16 - nx test ast-spec --coverage=false
• nx test eslint-plugin-internal --coverage=false
• Node 16 - nx test scope-manager --coverage=false
• Node 16 - nx test rule-schema-to-typescript-types --coverage=false
• nx test eslint-plugin --coverage=false
• Node 16 - nx test eslint-plugin-internal --coverage=false
• Node 16 - nx test type-utils --coverage=false
• Node 16 - nx test eslint-plugin --coverage=false
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint

---

Sent with 💌 from NxCloud.

[codecov]

Codecov Report

Merging #7410 (6bfd606) into main (49e5dd5) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7410      +/-   ##
==========================================
- Coverage   87.42%   87.34%   -0.09%     
==========================================
  Files         381      381              
  Lines       13324    13336      +12     
  Branches     3939     3943       +4     
==========================================
- Hits        11649    11648       -1     
- Misses       1297     1308      +11     
- Partials      378      380       +2     

Flag	Coverage Δ
unittest	87.34% <0.00%> (-0.09%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
packages/typescript-estree/src/convert.ts	29.83% <0.00%> (-0.21%)	⬇️
packages/typescript-estree/src/node-utils.ts	54.00% <0.00%> (-2.25%)	⬇️

[bradzacher]

thanks for looking into this!
looks like the logic isn't right still

[bradzacher]

this should be true

[sosukesuzuki]

Thank you. I've fixed f43949d and updated snapshots e8463d2

[EchoZhaoH]

The export keyword also needs to support

[bradzacher]

Oof yeah it looks like our handling is pretty shoddy overall:

declare namespace foo1 { } // ✅ declare: true
declare module foo2 { } // ✅ declare: true

declare namespace foo3.bar { } // ❌ declare: false
declare module foo4.def { } // ✅ declare: true

export declare namespace foo5 { } // ✅ export: "true"
                                  // ✅ declare: true
export declare module foo6 { } // ✅ export: "true"
                               // ✅ declare: true

export declare namespace foo7.bar { } // ❌ export: "false"
                                      // ❌ declare: false
export declare module foo8.def { } // ✅ export: "true"
                                   // ✅ declare: true

declare global { } // ✅ declare: true
                   // ✅ global: true
export declare global { } // ✅ export: "true"
                          // ✅ declare: true
                          // ✅ global: true

playground

If possible - can we add cases for and fix all of this at once?

[sosukesuzuki]

Hmm, codecov is also failing in the part that should have been tested. Am I wrong..?

[bradzacher]

nah our codecov setup just isn't able to collect coverage across packages right now, sadly.

[bradzacher]

thanks so much for fixing this - this fix LGTM!