Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript-estree): fix TSNode type error on old ts versions #7267

Merged
merged 1 commit into from Jul 19, 2023

Conversation

bradzacher
Copy link
Member

Overview

Found this when upgrading an internal codebase that's on TS4.9
Also realised we forgot to clean this up with the v6 min version bump!

@bradzacher bradzacher added the bug Something isn't working label Jul 19, 2023
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Jul 19, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 64fdb16
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/64b737714e08cd0007c34691
😎 Deploy Preview https://deploy-preview-7267--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud
Copy link

nx-cloud bot commented Jul 19, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 64fdb16. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 35 targets

Sent with 💌 from NxCloud.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha!

@bradzacher bradzacher merged commit f2aed1b into main Jul 19, 2023
48 of 49 checks passed
@bradzacher bradzacher deleted the fix-types-on-old-ts-versions branch July 19, 2023 02:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants