Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript-estree): remove ts.sys watch program override #7252

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Fixes the relativity issue more surgically than a full revert (#7251).

Co-authored-by: @bradzacher

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Jul 17, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 114d257
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/64b548f3e37c2b0008fd5259
😎 Deploy Preview https://deploy-preview-7252--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JoshuaKGoldberg
Copy link
Member Author

Confirmed that the Astro and trpc repos aren't impacted by the original bug. I'd previously tested my template-typescript-node-package repo. Shipping!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 41d6e9d into typescript-eslint:main Jul 17, 2023
46 of 48 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the fix-get-watch-programs-relativity branch July 17, 2023 14:14
@nx-cloud
Copy link

nx-cloud bot commented Jul 17, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 114d257. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 35 targets

Sent with 💌 from NxCloud.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants