Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Website: codeblock comments and unchanged diff lines don't have enough contrast #7171

Closed
2 tasks done
JoshuaKGoldberg opened this issue Jul 7, 2023 · 0 comments · Fixed by #7396
Closed
2 tasks done

Website: codeblock comments and unchanged diff lines don't have enough contrast #7171

JoshuaKGoldberg opened this issue Jul 7, 2023 · 0 comments · Fixed by #7396
Labels
accepting prs Go ahead, send a pull request that resolves this issue accessibility ("a11y"): making the site more accessible to all users bug Something isn't working documentation Documentation ("docs") that needs adding/updating

Comments

@JoshuaKGoldberg
Copy link
Member

Before You File a Documentation Request Please Confirm You Have Done The Following...

Suggested Changes

Similar to #5246, but for the unchanged lines - as well as comments in code.

Screenshot of an .eslintrc.cjs named codeblock with a comment. The comment is a light gray on the slightly lighter background.

Screenshot of the v6 blog post's "Diff Patch from v6..." details, expanded to show the first few lines of the diff. The unchanged lines are a light gray on the slightly lighter background.

Affected URL(s)

https://typescript-eslint.io/blog/announcing-typescript-eslint-v6 (once #5886 is merged)
https://typescript-eslint.io/linting/troubleshooting
@JoshuaKGoldberg JoshuaKGoldberg added bug Something isn't working documentation Documentation ("docs") that needs adding/updating accepting prs Go ahead, send a pull request that resolves this issue accessibility ("a11y"): making the site more accessible to all users labels Jul 7, 2023
@haocheng6 haocheng6 mentioned this issue Aug 1, 2023
Merged
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue accessibility ("a11y"): making the site more accessible to all users bug Something isn't working documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(website): improve contrast for comments and unchanged diff lines haocheng6/typescript-eslint
1 participant
@JoshuaKGoldberg