feat: support TypeScript 5.1 #7088

JoshuaKGoldberg · 2023-06-06T05:11:17Z

Note: This doesn't Block You From Linting TypeScript 5.1

You can still use typescript@>=5.1 with @typescript-eslint/eslint-plugin & @typescript-eslint/parser. There are no breaking changes in TS 5.1 that would block you from linting existing code. JSX namespaces (<MyComponent a:b />) should generally be linted properly.

Until this PR is merged and a new set of typescript-eslint package versions are released, your console may see a log like WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree..

Status Update: June 26th 2023

Looks like TypeScript's latest releases have fixed the issue. We should be ready to release a new version with this PR's changes soon - pending review.

Status Update: June 9 2023

This PR is blocked on out-of-memory (OOM) errors running a set of important unit tests for the parser. The OOM error only occurs with TypeScript 5.1, not locally.

We're working on identifying which commit to TypeScript introduced the change that coincides with this OOM error being introduced. In #7091 we narrowed it down as follows:

✅ Running with typescript@5.1.0-dev.20230301 does not exhibit the OOM error
❌ Running with typescript@5.1.0-dev.20230302 does exhibit the OOM error

~~Our next step will be to write a script to run against individual TypeScript commits.~~

It looks like microsoft/TypeScript#54542 is the root of the OOM. At least, from running on recent TypeScript commits, that's the first one that has the OOM occur. TBD once it's fixed.

Thanks to @jakebailey from the TypeScript team for helping us with this! ❤️

PR Checklist

Addresses an existing open issue: fixes TypeScript 5.1 Support #6934
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

Bumps the supported ranges per https://typescript-eslint.io/maintenance/versioning/dependant-version-upgrades#adding-support-for-a-new-typescript-version. Since we didn't have an RC PR, this merges the PR steps a bit.

typescript-eslint · 2023-06-06T05:11:20Z

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2023-06-06T05:11:22Z

❌ Deploy Preview for typescript-eslint failed.

Name	Link
🔨 Latest commit	`3a01637`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/649f1795a0c6860007244359

package.json

packages/typescript-estree/src/convert.ts

patches/typescript+5.1.3.patch

nx-cloud · 2023-06-07T00:11:40Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3a01637. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 25 targets

Sent with 💌 from NxCloud.

packages/ast-spec/tsconfig.build.json

JoshuaKGoldberg · 2023-06-07T04:58:25Z

Run ./.github/actions/wait-for-netlify
/home/runner/work/typescript-eslint/typescript-eslint/node_modules/@actions/core/lib/core.js:106
        throw new Error(`Input required and not supplied: ${name}`);
        ^

Error: Input required and not supplied: netlify_token

@JamesHenry something funky with the new action, perhaps? https://github.com/typescript-eslint/typescript-eslint/actions/runs/5195237524/jobs/9367800550?pr=7088

JoshuaKGoldberg · 2023-06-07T05:04:54Z

PASS  tests/lib/node-utils.test.ts
 PASS  tests/lib/parse.project-true.test.ts
<--- Last few GCs --->
[2972:0x61b15c0]   201164 ms: Mark-sweep (reduce) 2037.5 (2051.0) -> 2036.7 (2052.5) MB, 2662.2 / 0.0 ms  (average mu = 0.171, current mu = 0.014) allocation failure scavenge might not succeed
[2972:0x61b15c0]   203868 ms: Mark-sweep (reduce) 2037.8 (2051.5) -> 2037.3 (2052.8) MB, [26](https://github.com/typescript-eslint/typescript-eslint/actions/runs/5195237524/jobs/9367799309?pr=7088#step:6:27)32.6 / 0.0 ms  (average mu = 0.102, current mu = 0.026) allocation failure scavenge might not succeed
<--- JS stacktrace --->
FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0xa3ad50 node::Abort() [/opt/hostedtoolcache/node/14.21.3/x64/bin/node]

sigh.

bradzacher

One case that would be worth adding a test for:
<foo-bar:baz-bam />

Both the ns and name of the namespace are allowed to be valid JSX identifiers!

Otherwise this is all LGTM
Once you land it we can do an out-of-band release to get it out and keep the early adopters happy!

packages/typescript-estree/src/convert.ts

bradzacher · 2023-06-07T05:17:13Z

packages/scope-manager/tests/fixtures/jsx/namespaced-attribute.tsx

+
+// Both of these are equivalent:
+const x = <Foo a:b="hello" />;
+const y = <Foo a : b="hello" />;


cool - this case actually used to be an error pre 5.1!

JamesHenry · 2023-06-07T06:58:47Z

Run ./.github/actions/wait-for-netlify
/home/runner/work/typescript-eslint/typescript-eslint/node_modules/@actions/core/lib/core.js:106
        throw new Error(`Input required and not supplied: ${name}`);
        ^

Error: Input required and not supplied: netlify_token
@JamesHenry something funky with the new action, perhaps? https://github.com/typescript-eslint/typescript-eslint/actions/runs/5195237524/jobs/9367800550?pr=7088

Oh sorry, I reckon it could be that the secret doesn’t work as an input when you’re coming from a fork…

I will figure out how this has been workable for other actions in the past

JamesHenry · 2023-06-07T10:50:49Z

@JoshuaKGoldberg @bradzacher I can't find any evidence that this ever worked. I think the secret won't be populated on forks which makes sense.

I have therefore just pushed a commit to the branch which should should hopefully amend things to only run the Website Tests when not on a fork

JamesHenry · 2023-06-07T11:20:10Z

I thought that should work based on this answer: https://github.com/orgs/community/discussions/26409#discussioncomment-3251822

anyone know the right syntax here?

bradzacher · 2023-06-07T13:52:24Z

That's all we've got here:

typescript-eslint/.github/workflows/ci.yml

Line 248 in a2b6b2e

    
           if: github.repository == 'typescript-eslint/typescript-eslint' && github.ref == 'refs/heads/main'

IDK why it wouldn't be working there?

bradzacher · 2023-06-07T22:16:45Z

@JoshuaKGoldberg once you've got all the tests passing locally feel free to just land this to main.

We can follow up with a fix commit if any CIs fail on main.

This reverts commit c6f949b.

JoshuaKGoldberg · 2023-06-09T07:00:49Z

Ah, this may be from a different TypeScript issue likely to be fixed soon: microsoft/TypeScript#54542

packages/typescript-estree/tests/fixtures/simpleProject/tsconfig.json

codecov · 2023-06-26T23:06:20Z

Codecov Report

Merging #7088 (3a01637) into main (f74862c) will decrease coverage by 0.04%.
The diff coverage is 33.33%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7088      +/-   ##
==========================================
- Coverage   87.43%   87.39%   -0.04%     
==========================================
  Files         386      386              
  Lines       13192    13198       +6     
  Branches     3872     3873       +1     
==========================================
+ Hits        11534    11535       +1     
- Misses       1292     1296       +4     
- Partials      366      367       +1

Flag	Coverage Δ
unittest	`87.39% <33.33%> (-0.04%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/typescript-estree/src/convert.ts	`29.22% <0.00%> (-0.15%)`	⬇️
...ipt-estree/src/parseSettings/warnAboutTSVersion.ts	`93.33% <100.00%> (ø)`

... and 2 files with indirect coverage changes

bradzacher · 2023-06-27T01:37:56Z

package.json

@@ -112,10 +111,10 @@
    "ts-node": "10.7.0",
    "tslint": "^6.1.3",
    "tsx": "^3.12.1",
-    "typescript": ">=3.3.1 <5.1.0"
+    "typescript": "npm:@typescript-deploys/pr-build@5.2.0-pr-54781-9"


@JoshuaKGoldberg is the regression going to be patch fixed in 5.1? Or is it going to wait for 5.2?

@jakebailey indicated it should be patched soon

Yeah there will be a patch release of 5.1 in the next day or so.

5.1.6 is out on npm since yesterday, although not visible in https://github.com/microsoft/TypeScript/releases yet.

JoshuaKGoldberg · 2023-07-06T19:33:32Z

packages/typescript-estree/jest.config.js

 // @ts-check
+
+const ts = require('typescript');
+console.log('Running with TypeScript version:', ts.version);


oops, meant to remove this... will do later 😄

Summary: To get the fixes from [this saga of bugs](typescript-eslint/typescript-eslint#7088). Relevant Issues: N/A Type of change: /kind bugfix Test Plan: `yarn typecheck && yarn lint`. Editors should still behave. Signed-off-by: Nick Lanam <nlanam@pixielabs.ai>

JoshuaKGoldberg commented Jun 6, 2023

View reviewed changes

package.json Show resolved Hide resolved

JoshuaKGoldberg commented Jun 6, 2023

View reviewed changes

packages/typescript-estree/src/convert.ts Show resolved Hide resolved

feat: support TypeScript 5.1

16d750f

JoshuaKGoldberg force-pushed the typescript-5.1 branch from c975543 to 16d750f Compare June 6, 2023 05:16

JoshuaKGoldberg commented Jun 6, 2023

View reviewed changes

patches/typescript+5.1.3.patch Outdated Show resolved Hide resolved

Re-apply patch-package typescript

45e19f8

jsx: preserve in ast-spec

07a8a85

JoshuaKGoldberg marked this pull request as ready for review June 7, 2023 02:15

JoshuaKGoldberg commented Jun 7, 2023

View reviewed changes

packages/ast-spec/tsconfig.build.json Show resolved Hide resolved

bradzacher previously approved these changes Jun 7, 2023

View reviewed changes

bradzacher added the New TypeScript Version label Jun 7, 2023

Added component-dashed fixture

a000e00

JoshuaKGoldberg dismissed bradzacher’s stale review via a000e00 June 7, 2023 05:28

Rename to avoid global naming conflict

65ae4f9

chore: only run website tests on non-forks

676e900

chore: only run website tests on non-forks

8bf3877

JoshuaKGoldberg added 2 commits June 8, 2023 07:44

Updated ast-spec snapshots

16553c6

Let's try --runInBand

4bd4879

JoshuaKGoldberg added 2 commits June 8, 2023 08:40

How about some logging

6931b54

--verbose

ea0e298

JoshuaKGoldberg added 2 commits June 9, 2023 03:57

Heck, let's try Node 20

c6f949b

Revert "Heck, let's try Node 20"

564f73d

This reverts commit c6f949b.

JoshuaKGoldberg mentioned this pull request Jun 8, 2023

Repo: Add a way to detect breakages from new TS versions sooner #7093

Open

jakebailey mentioned this pull request Jun 9, 2023

5.1 regression from 5.0: JavaScript heap out of memory (Type instantiation is excessively deep and possibly infinit) microsoft/TypeScript#54542

Closed

JoshuaKGoldberg added 2 commits June 9, 2023 16:40

skipLibCheck and strict

f54f303

Undid some changes, for 5.1.3 again

8dba084

JoshuaKGoldberg commented Jun 9, 2023

View reviewed changes

packages/typescript-estree/tests/fixtures/simpleProject/tsconfig.json Show resolved Hide resolved

Mitsunee mentioned this pull request Jun 12, 2023

update: typescript to 5.1 - autoclosed foxkit-js/node-util#5

Closed

1 task

JoshuaKGoldberg mentioned this pull request Jun 13, 2023

feat(typescript-estree): add EXPERIMENTAL_useProjectService option to use TypeScript project service #6754

Merged

3 tasks

hildjj mentioned this pull request Jun 24, 2023

Update dependencies, add new rule jsdoc/imports-as-dependencies cto-af/eslint-config#10

Merged

mckelveygreg mentioned this pull request Jun 26, 2023

bump for ts 5.1 twentyideas/eslint-config-20i#18

Closed

JoshuaKGoldberg added 2 commits June 26, 2023 15:22

Used new resolution courtesy of Jake

a2b5fcd

Merge branch 'main'

f79242b

JoshuaKGoldberg removed the blocked by another issue Issues which are not ready because another issue needs to be resolved first label Jun 26, 2023

Corrected TypeScript patching and resolution

cb4b668

Fix packages/website/tsconfig.json module

f978c76

JoshuaKGoldberg requested a review from bradzacher June 26, 2023 23:24

bradzacher reviewed Jun 27, 2023

View reviewed changes

JoshuaKGoldberg added 2 commits June 30, 2023 10:53

5.1.6

10bdc43

Recreated patch-package typescript

3a01637

JoshuaKGoldberg merged commit 4bf2d73 into typescript-eslint:main Jun 30, 2023
36 of 43 checks passed

JoshuaKGoldberg deleted the typescript-5.1 branch June 30, 2023 23:21

JoshuaKGoldberg commented Jul 6, 2023

View reviewed changes

JoshuaKGoldberg mentioned this pull request Jul 6, 2023

Repo: v6 branch regression for adding to JSX.IntrinsicAttributes in typecheck task #7166

Closed

rubiesonthesky mentioned this pull request Jul 6, 2023

Repo: Docusaurus builds are broken on main #7165

Closed

NickLanam mentioned this pull request Jul 11, 2023

[chore] Update @typescript-eslint pixie-io/pixie#1608

Merged

github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: support TypeScript 5.1 #7088

feat: support TypeScript 5.1 #7088

JoshuaKGoldberg commented Jun 6, 2023 •

edited

typescript-eslint bot commented Jun 6, 2023

netlify bot commented Jun 6, 2023 •

edited

nx-cloud bot commented Jun 7, 2023 •

edited

JoshuaKGoldberg commented Jun 7, 2023

JoshuaKGoldberg commented Jun 7, 2023

bradzacher left a comment

bradzacher Jun 7, 2023

JamesHenry commented Jun 7, 2023 •

edited

JamesHenry commented Jun 7, 2023

JamesHenry commented Jun 7, 2023

bradzacher commented Jun 7, 2023

bradzacher commented Jun 7, 2023

JoshuaKGoldberg commented Jun 9, 2023 •

edited

codecov bot commented Jun 26, 2023 •

edited

bradzacher Jun 27, 2023

JoshuaKGoldberg Jun 27, 2023

jakebailey Jun 27, 2023

wojtekmaj Jun 30, 2023

JoshuaKGoldberg Jul 6, 2023

feat: support TypeScript 5.1 #7088

feat: support TypeScript 5.1 #7088

Conversation

JoshuaKGoldberg commented Jun 6, 2023 • edited

Note: This doesn't Block You From Linting TypeScript 5.1

Status Update: June 26th 2023

Status Update: June 9 2023

PR Checklist

Overview

typescript-eslint bot commented Jun 6, 2023

netlify bot commented Jun 6, 2023 • edited

❌ Deploy Preview for typescript-eslint failed.

nx-cloud bot commented Jun 7, 2023 • edited

☁️ Nx Cloud Report

JoshuaKGoldberg commented Jun 7, 2023

JoshuaKGoldberg commented Jun 7, 2023

bradzacher left a comment

Choose a reason for hiding this comment

bradzacher Jun 7, 2023

Choose a reason for hiding this comment

JamesHenry commented Jun 7, 2023 • edited

JamesHenry commented Jun 7, 2023

JamesHenry commented Jun 7, 2023

bradzacher commented Jun 7, 2023

bradzacher commented Jun 7, 2023

JoshuaKGoldberg commented Jun 9, 2023 • edited

codecov bot commented Jun 26, 2023 • edited

Codecov Report

bradzacher Jun 27, 2023

Choose a reason for hiding this comment

JoshuaKGoldberg Jun 27, 2023

Choose a reason for hiding this comment

jakebailey Jun 27, 2023

Choose a reason for hiding this comment

wojtekmaj Jun 30, 2023

Choose a reason for hiding this comment

JoshuaKGoldberg Jul 6, 2023

Choose a reason for hiding this comment

JoshuaKGoldberg commented Jun 6, 2023 •

edited

netlify bot commented Jun 6, 2023 •

edited

nx-cloud bot commented Jun 7, 2023 •

edited

JamesHenry commented Jun 7, 2023 •

edited

JoshuaKGoldberg commented Jun 9, 2023 •

edited

codecov bot commented Jun 26, 2023 •

edited