Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update the 'Major Release Steps' docs for what we did to release v6 #6761

Closed
2 tasks done
JoshuaKGoldberg opened this issue Mar 24, 2023 · 4 comments · Fixed by #8913
Closed
2 tasks done

Docs: Update the 'Major Release Steps' docs for what we did to release v6 #6761

JoshuaKGoldberg opened this issue Mar 24, 2023 · 4 comments · Fixed by #8913
Assignees
Labels
accepting prs Go ahead, send a pull request that resolves this issue documentation Documentation ("docs") that needs adding/updating
Milestone

Comments

@JoshuaKGoldberg
Copy link
Member

Before You File a Documentation Request Please Confirm You Have Done The Following...

Suggested Changes

We've done a few things to prep v6 that aren't in the docs yet. They should be documented.

At the very least:

Affected URL(s)

https://typescript-eslint.io/maintenance/releases#major-release-steps

@JoshuaKGoldberg JoshuaKGoldberg added documentation Documentation ("docs") that needs adding/updating accepting prs Go ahead, send a pull request that resolves this issue labels Mar 24, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Mar 24, 2023
@JoshuaKGoldberg
Copy link
Member Author

JoshuaKGoldberg commented Jul 10, 2023

Additionally:

@JoshuaKGoldberg
Copy link
Member Author

I think we'll need to update the list of expected status checks for the PRs whenever we update a Node version, too.

Screenshot of several Run Unit Tests (18, ...) status checks still waiting to be reported in GitHub

@bradzacher
Copy link
Member

I think we'll need to update the list of expected status checks for the PRs whenever we update a Node version, too.

I just did that yeah - that's not specifically a major release thing though - that's just a CI change step - but we happened to change the min AND max node versions in this major which meant that all the old required steps are now out-of-date.

I just updated it all.
Steps are:

  1. https://github.com/typescript-eslint/typescript-eslint/settings/branches
  2. edit the main branch protection
  3. remove the now obsolete steps from "Status checks that are required."
  4. add the new steps to "Status checks that are required."

NOTE: this sucks, the UI sucks, and it's a pain in the ass to do, sadly.

@JamesHenry
Copy link
Member

TODO for this is updating the text to reference nx release rather than lerna and tweak the instructions accordingly

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepting prs Go ahead, send a pull request that resolves this issue documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants