Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: v6 eslint-plugin package doesn't allow v6 parser to satisfy peerDependency #6634

Closed
JoshuaKGoldberg opened this issue Mar 14, 2023 · 1 comment
Assignees
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Milestone

Comments

@JoshuaKGoldberg
Copy link
Member

Suggestion

Just filing an issue for tracking: #6630 fixes this.

After going through the steps in https://typescript-eslint.io/blog/announcing-typescript-eslint-v6-beta#trying-out-v6 to install the v6 package versions:

npm i @typescript-eslint/eslint-plugin@rc-v6 @typescript-eslint/parser@rc-v6 --save-dev

npm will give a complaint:

joshgoldberg ~/repos/TypeScript $ npm i
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: typescript@5.1.0
npm ERR! Found: @typescript-eslint/parser@6.0.0-alpha.81
npm ERR! node_modules/@typescript-eslint/parser
npm ERR!   dev @typescript-eslint/parser@"^6.0.0-alpha.81" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @typescript-eslint/parser@"^5.0.0" from @typescript-eslint/eslint-plugin@6.0.0-alpha.81
npm ERR! node_modules/@typescript-eslint/eslint-plugin
npm ERR!   dev @typescript-eslint/eslint-plugin@"^6.0.0-alpha.81" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /Users/josh/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/josh/.npm/_logs/2023-03-14T07_47_53_197Z-debug-0.log

The problem is the @typescript-eslint/eslint-plugin package lists its @typescript-eslint/parser peerDependency as ^5.0.0. That doesn't allow for 6.x versions.

@JoshuaKGoldberg JoshuaKGoldberg added bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin accepting prs Go ahead, send a pull request that resolves this issue labels Mar 14, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Mar 14, 2023
@JoshuaKGoldberg
Copy link
Member Author

Resolved by #6630.

@JoshuaKGoldberg JoshuaKGoldberg added this to the 6.0.0 milestone Mar 19, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Development

No branches or pull requests

1 participant