New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(typescript-estree): support const
modifiers for type parameters
#6600
feat(typescript-estree): support const
modifiers for type parameters
#6600
Conversation
Thanks for the PR, @sosukesuzuki! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
efae48f
to
76ca8e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the change and fixtures LGTM!
@sosukesuzuki what fixtures need to be added? Looks like it's pretty good coverage? |
Ah sorry, nothing. The PR description is written before adding fixtures. |
Sweet - this is perfect then! We can get this in for the next release and we'll have 5.0 support!! |
f3c6373
into
typescript-eslint:main
Thank you for reviewing & merging this! |
PR Checklist
Overview
Based on #6570
Supports https://devblogs.microsoft.com/typescript/announcing-typescript-5-0-rc/#const-type-parameters
TODO:
@babel/parser
#6599 is merged, adds test fixtures.