Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typescript-estree): support const modifiers for type parameters #6600

Merged
merged 27 commits into from Mar 13, 2023

Conversation

sosukesuzuki
Copy link
Contributor

@sosukesuzuki sosukesuzuki commented Mar 11, 2023

PR Checklist

Overview

Based on #6570

Supports https://devblogs.microsoft.com/typescript/announcing-typescript-5-0-rc/#const-type-parameters

TODO:

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @sosukesuzuki!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloud bot commented Mar 11, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit fe38c86. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


🟥 Failed Commands
Node 14 - nx test typescript-estree --coverage=false
Node 18 - nx test typescript-estree
✅ Successfully ran 36 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Mar 11, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit fe38c86
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/640e81d48302ab0007d74b39
😎 Deploy Preview https://deploy-preview-6600--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the change and fixtures LGTM!

@bradzacher
Copy link
Member

When #6599 is merged, adds test fixtures.

@sosukesuzuki what fixtures need to be added? Looks like it's pretty good coverage?

@sosukesuzuki
Copy link
Contributor Author

what fixtures need to be added? Looks like it's pretty good coverage?

Ah sorry, nothing. The PR description is written before adding fixtures.

@bradzacher bradzacher marked this pull request as ready for review March 13, 2023 02:02
@bradzacher
Copy link
Member

Sweet - this is perfect then! We can get this in for the next release and we'll have 5.0 support!!

@bradzacher bradzacher added enhancement New feature or request AST PRs and Issues about the AST structure labels Mar 13, 2023
@JoshuaKGoldberg JoshuaKGoldberg merged commit f3c6373 into typescript-eslint:main Mar 13, 2023
28 of 37 checks passed
@sosukesuzuki
Copy link
Contributor Author

Thank you for reviewing & merging this!

@sosukesuzuki sosukesuzuki deleted the const-parameters branch March 13, 2023 05:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
AST PRs and Issues about the AST structure enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants