feat(eslint-plugin): [restrict-plus-operands] add allow* options

[JoshuaKGoldberg]

PR Checklist

• Addresses an existing open issue: fixes Enhancement: [restrict-plus-operands] Bring in options from restrict-template-expressions #6110
• That issue was marked as accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

Brings in the allowBoolean, allowNullish, and allowRegExp options from @typescript-eslint/restrict-template-expressions. Also adds an allowNumberWithString option equivalent to the allowNumber option, as a more-specific-to-this-rule name.

Internally streamlines the rule a bit by having comparisons directly refer to ts.TypeFlags checks whenever possible.

[typescript-eslint]

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 548b7df. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 47 targets

• Node 18 - nx test @typescript-eslint/eslint-plugin
• Node 14 - nx test @typescript-eslint/eslint-plugin --coverage=false
• Node 18 - nx test @typescript-eslint/visitor-keys
• nx run-many --target=typecheck --all --parallel
• nx run-many --target=lint --all --parallel
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/utils
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/parser --coverage=false
• Node 18 - nx test @typescript-eslint/eslint-plugin-internal
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/type-utils
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/ast-spec
• Node 14 - nx test @typescript-eslint/typescript-estree --coverage=false
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/scope-manager --coverage=false
• Node 18 - nx test @typescript-eslint/eslint-plugin-tslint
• Node 18 - nx test @typescript-eslint/typescript-estree
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/ast-spec --coverage=false
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/utils --coverage=false
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/type-utils --coverage=false
• Node 18 - nx test @typescript-eslint/scope-manager
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/visitor-keys --coverage=false
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/eslint-plugin-internal --coverage=false
• Node 14 - nx test @typescript-eslint/eslint-plugin-tslint --coverage=false
• Node 18 - nx test @typescript-eslint/parser
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website

---

Sent with 💌 from NxCloud.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	548b7df
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/638b0ee56015fb00081386a5
😎 Deploy Preview	https://deploy-preview-6161--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[JoshuaKGoldberg]

These three inner if (types.some(... cases weren't covered by code coverage. Most of the intersections in the previous test suite reduced to never. I got rid of most of them.

[codecov]

Codecov Report

Merging #6161 (548b7df) into main (e458b5a) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6161      +/-   ##
==========================================
+ Coverage   91.26%   91.31%   +0.04%     
==========================================
  Files         366      366              
  Lines       12427    12426       -1     
  Branches     3639     3644       +5     
==========================================
+ Hits        11342    11347       +5     
+ Misses        774      768       -6     
  Partials      311      311              

Flag	Coverage Δ
unittest	91.31% <100.00%> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...-plugin/src/rules/restrict-template-expressions.ts	100.00% <ø> (ø)
.../eslint-plugin/src/rules/restrict-plus-operands.ts	100.00% <100.00%> (+11.32%)	⬆️

[JoshuaKGoldberg]

Drafting this pending discussion in #6110

Changes applied

[bradzacher]

Yeah looks good - nice and loud and explicit to help people understand better practices