Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Remove 2 year old backwards compatibility check from getParserServices #5508

Closed
4 tasks done
JoshuaKGoldberg opened this issue Aug 18, 2022 · 2 comments · Fixed by #6066
Closed
4 tasks done
Assignees
Labels
breaking change This change will require a new major version to be released enhancement New feature or request package: utils Issues related to the @typescript-eslint/utils package
Milestone

Comments

@JoshuaKGoldberg
Copy link
Member

Before You File a Proposal Please Confirm You Have Done The Following...

Relevant Package

utils

My proposal is suitable for this project

  • I believe my proposal would be useful to the broader TypeScript community (meaning it is not a niche proposal).

Description

The getParserServices function contains this comment:

// backwards compatibility check
// old versions of the parser would not return any parserServices unless parserOptions.project was set

Additionally, later on in that file:

const hasFullTypeInformation =
  context.parserServices.hasFullTypeInformation ??
  /* backwards compatible */ true;

Does that mean we can get rid of some of the code in that file?

Fail

n/a

Pass

n/a

Additional Info

No response

@JoshuaKGoldberg JoshuaKGoldberg added enhancement New feature or request triage Waiting for maintainers to take a look package: utils Issues related to the @typescript-eslint/utils package labels Aug 18, 2022
@JoshuaKGoldberg
Copy link
Member Author

Not time sensitive at all, but assigning @bradzacher per the Git blame for triage.

@JoshuaKGoldberg JoshuaKGoldberg added accepting prs Go ahead, send a pull request that resolves this issue triage Waiting for maintainers to take a look and removed triage Waiting for maintainers to take a look accepting prs Go ahead, send a pull request that resolves this issue labels Sep 14, 2022
@JoshuaKGoldberg JoshuaKGoldberg added this to the 6.0.0 milestone Oct 29, 2022
@bradzacher bradzacher added triage Waiting for maintainers to take a look breaking change This change will require a new major version to be released and removed triage Waiting for maintainers to take a look labels Nov 23, 2022
@bradzacher bradzacher linked a pull request Nov 23, 2022 that will close this issue
3 tasks
@bradzacher
Copy link
Member

This has been merged into the v6 branch

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking change This change will require a new major version to be released enhancement New feature or request package: utils Issues related to the @typescript-eslint/utils package
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants