Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.16.1 patches #673

Merged
merged 3 commits into from
Feb 7, 2024
Merged

v1.16.1 patches #673

merged 3 commits into from
Feb 7, 2024

Conversation

twmb
Copy link
Owner

@twmb twmb commented Feb 7, 2024

No description provided.

twmb added 3 commits February 6, 2024 17:32
Previously, if CommitOffsetsSync was called during a rebalance, and the
context being used is canceled while the rebalance was occurring, then
the client would deadlock.

Internally, committing is blocked if a rebalance is actively happening.
There's some complex logic to have, effectively, a cancelable lock
if the user wants to not wait for a rebalance to complete while trying
to commit offsets.

There was a bug, and since the fix is one line, it's easier to see than
explain.

Closes #668.
@twmb twmb merged commit 41f0269 into master Feb 7, 2024
6 checks passed
@twmb twmb deleted the patch branch February 7, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant