Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid encode/decode in chat.py for better readablity #12102

Closed
snosratiershad opened this issue Feb 4, 2024 · 0 comments · Fixed by #12103
Closed

Avoid encode/decode in chat.py for better readablity #12102

snosratiershad opened this issue Feb 4, 2024 · 0 comments · Fixed by #12103
Labels
documentation

Comments

@snosratiershad
Copy link
Contributor

As discussed in this comment, it's better to use byte concat as mentioned in order of better readability in docs/core/howto/listings/servers/chat.py:35

message = b'<' + self.name + b'> ' + message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#12102 chat.py example changed to byte concat instead of decode/encode snosratiershad/twisted
1 participant
@snosratiershad