Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#11902 - Fix type for twisted.web.server.Request.defaultContentType #12101

Merged
merged 3 commits into from Feb 1, 2024
Merged

#11902 - Fix type for twisted.web.server.Request.defaultContentType #12101

merged 3 commits into from Feb 1, 2024

Conversation

eevelweezel
Copy link
Contributor

Scope and purpose

Fixes #11902

Set type for twisted.web.server.Request.defaultContentType to allow bytes or None.

@eevelweezel
Copy link
Contributor Author

needs-review

@chevah-robot chevah-robot requested a review from a team February 1, 2024 03:03
adiroiban
adiroiban approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. All good! I will merge.

@adiroiban adiroiban merged commit 234f378 into twisted:trunk Feb 1, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adiroiban adiroiban adiroiban approved these changes

Assignees
No one assigned
Labels
needs-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

twisted.web.server.Request.defaultContentType is missing type annotation
3 participants
@eevelweezel @adiroiban @chevah-robot