Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove redundant allow_untyped_defs = false mypy overrides section #11945

Closed
graingert opened this issue Sep 1, 2023 · 1 comment · Fixed by #11946
Closed

remove redundant allow_untyped_defs = false mypy overrides section #11945

graingert opened this issue Sep 1, 2023 · 1 comment · Fixed by #11946

Comments

@graingert
Copy link
Member 

          hmm, this feels like a place we should be strictly removing stuff from a list, rather than adding to one. do you know if there's a reason it was set up this way?

Originally posted by @glyph in #11943 (comment)
@graingert
Copy link
Member Author

turns out disallow_untyped_defs is already the default

twisted/pyproject.toml

Line 293 in 841c31a

disallow_untyped_defs = true

so really there's just a redundant config section

@graingert graingert changed the title make disallow_untyped_defs the default remove redundant allow_untyped_defs = false mypy overrides section Sep 1, 2023
@graingert graingert mentioned this issue Sep 1, 2023
Merged
graingert added a commit that referenced this issue Sep 2, 2023
@graingert
#11945 opt into mypy strict by default, remove redundant mypy overrid…
4e8aef0 
…es (#11946)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#11945 opt into mypy strict by default, remove redundant mypy overrides twisted/twisted
2 participants
@graingert and others