-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#11920 move mypy config to pyproject.toml #11921
#11920 move mypy config to pyproject.toml #11921
Conversation
[[tool.mypy.overrides]] | ||
allow_untyped_defs = true | ||
module = [ | ||
'twisted.application.test.test_service', | ||
'twisted.python._pydoctor', | ||
'twisted.python._release', | ||
'twisted.python._shellcomp', | ||
'twisted.python._textattributes', | ||
'twisted.python.compat', | ||
'twisted.python.components', | ||
'twisted.python.context', | ||
'twisted.python.deprecate', | ||
'twisted.python.fakepwd', | ||
'twisted.python.htmlizer', | ||
'twisted.python.lockfile', | ||
'twisted.python.log', | ||
'twisted.python.monkey', | ||
'twisted.python.procutils', | ||
'twisted.python.randbytes', | ||
'twisted.python.release', | ||
'twisted.python.roots', | ||
'twisted.python.shortcut', | ||
'twisted.python.syslog', | ||
'twisted.python.test.test_dist3', | ||
'twisted.python.test.test_htmlizer', | ||
'twisted.python.test.test_runtime', | ||
'twisted.python.test.test_setup', | ||
'twisted.python.test.test_textattributes', | ||
'twisted.python.test.test_tzhelper', | ||
'twisted.python.test.test_versions', | ||
'twisted.python.test.test_win32', | ||
'twisted.python.test.test_zippath', | ||
'twisted.python.threadpool', | ||
'twisted.python.zippath', | ||
'twisted.runner.inetdtap', | ||
'twisted.runner.procmontap', | ||
'twisted.runner.inetdconf', | ||
'twisted.runner.test.test_procmontap', | ||
] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[[tool.mypy.overrides]] | |
allow_untyped_defs = true | |
module = [ | |
'twisted.application.test.test_service', | |
'twisted.python._pydoctor', | |
'twisted.python._release', | |
'twisted.python._shellcomp', | |
'twisted.python._textattributes', | |
'twisted.python.compat', | |
'twisted.python.components', | |
'twisted.python.context', | |
'twisted.python.deprecate', | |
'twisted.python.fakepwd', | |
'twisted.python.htmlizer', | |
'twisted.python.lockfile', | |
'twisted.python.log', | |
'twisted.python.monkey', | |
'twisted.python.procutils', | |
'twisted.python.randbytes', | |
'twisted.python.release', | |
'twisted.python.roots', | |
'twisted.python.shortcut', | |
'twisted.python.syslog', | |
'twisted.python.test.test_dist3', | |
'twisted.python.test.test_htmlizer', | |
'twisted.python.test.test_runtime', | |
'twisted.python.test.test_setup', | |
'twisted.python.test.test_textattributes', | |
'twisted.python.test.test_tzhelper', | |
'twisted.python.test.test_versions', | |
'twisted.python.test.test_win32', | |
'twisted.python.test.test_zippath', | |
'twisted.python.threadpool', | |
'twisted.python.zippath', | |
'twisted.runner.inetdtap', | |
'twisted.runner.procmontap', | |
'twisted.runner.inetdconf', | |
'twisted.runner.test.test_procmontap', | |
] |
pretty sure this config block is redundant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to delete this.
As long as mypy check is green, this should be ok.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do this in a follow up I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the cleanup!
Please merge as you want :)
[[tool.mypy.overrides]] | ||
allow_untyped_defs = true | ||
module = [ | ||
'twisted.application.test.test_service', | ||
'twisted.python._pydoctor', | ||
'twisted.python._release', | ||
'twisted.python._shellcomp', | ||
'twisted.python._textattributes', | ||
'twisted.python.compat', | ||
'twisted.python.components', | ||
'twisted.python.context', | ||
'twisted.python.deprecate', | ||
'twisted.python.fakepwd', | ||
'twisted.python.htmlizer', | ||
'twisted.python.lockfile', | ||
'twisted.python.log', | ||
'twisted.python.monkey', | ||
'twisted.python.procutils', | ||
'twisted.python.randbytes', | ||
'twisted.python.release', | ||
'twisted.python.roots', | ||
'twisted.python.shortcut', | ||
'twisted.python.syslog', | ||
'twisted.python.test.test_dist3', | ||
'twisted.python.test.test_htmlizer', | ||
'twisted.python.test.test_runtime', | ||
'twisted.python.test.test_setup', | ||
'twisted.python.test.test_textattributes', | ||
'twisted.python.test.test_tzhelper', | ||
'twisted.python.test.test_versions', | ||
'twisted.python.test.test_win32', | ||
'twisted.python.test.test_zippath', | ||
'twisted.python.threadpool', | ||
'twisted.python.zippath', | ||
'twisted.runner.inetdtap', | ||
'twisted.runner.procmontap', | ||
'twisted.runner.inetdconf', | ||
'twisted.runner.test.test_procmontap', | ||
] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to delete this.
As long as mypy check is green, this should be ok.
Thanks
Scope and purpose
Fixes #11920