Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

twisted.web.server.Request.defaultContentType is missing type annotation #11902

Closed
itamarst opened this issue Jul 28, 2023 · 0 comments · Fixed by #12101
Closed

twisted.web.server.Request.defaultContentType is missing type annotation #11902

itamarst opened this issue Jul 28, 2023 · 0 comments · Fixed by #12101
Labels
bug

Comments

@itamarst
Copy link
Contributor

itamarst commented Jul 28, 2023 •
edited

MyPy assumes it's always bytes, but docs explain it can also be None, so really it should be Optional[bytes].
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#11902 - Fix type for twisted.web.server.Request.defaultContentType eevelweezel/twisted
1 participant
@itamarst