Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated BadZipfile with BadZipFile #11821

Merged
merged 2 commits into from Mar 12, 2023

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Mar 12, 2023

Scope and purpose

BadZipfile (with a small f) has been deprecated since Python 3.2, use BadZipFile (big F) instead, added in 3.2.

Contributor Checklist:

This process applies to all pull requests - no matter how small.
Have a look at our developer documentation before submitting your Pull Request.

Below is a non-exhaustive list (as a reminder):

  • The title of the PR should describe the changes and starts with the associated issue number, like “#9782 Remove twisted.news. #1234 Brief description”.
  • A release notes news fragment file was create in src/twisted/newsfragments/ (see: Release notes fragments docs.)
  • The automated tests were updated.
  • Once all checks are green, request a review by leaving a comment that contains exactly the string please review.
    Our bot will trigger the review process, by applying the pending review label
    and requesting a review from the Twisted dev team.

@hugovk
Copy link
Contributor Author

hugovk commented Mar 12, 2023

please review

@chevah-robot chevah-robot requested a review from a team March 12, 2023 18:34
Copy link
Member

@glyph glyph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing, looks great. Love to have fewer deprecation warnings.

@glyph glyph merged commit 22956b4 into twisted:trunk Mar 12, 2023
19 checks passed
@hugovk hugovk deleted the replace-deprecated-BadZipFile branch March 12, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants