Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PortableGIReactor is obsolete #11738

Closed
exarkun opened this issue Nov 2, 2022 · 0 comments · Fixed by #11739
Closed

PortableGIReactor is obsolete #11738

exarkun opened this issue Nov 2, 2022 · 0 comments · Fixed by #11739

Comments

@exarkun
Copy link
Member

exarkun commented Nov 2, 2022 •
edited

In history, glib didn't support sockets on Windows so Twisted implemented PortableGIReactor which does socket handling with selectreactor and uses glib for glib stuff.

In 2016 or so, glib fixed this oversight so now you can use sockets as channels with glib on Windows.

Thus, PortableGIReactor is no longer needed and the regular GIReactor is fine.

Make PortableGIReactor an alias for GIReactor instead of its own separate weird thing.
@exarkun exarkun changed the title PortableGtkReactor is obsolete PortableGIReactor is obsolete Nov 2, 2022
@glyph glyph mentioned this issue Nov 2, 2022
Merged
glyph added a commit that referenced this issue Nov 22, 2022
@glyph
#11738 portable gi obsolete (#11739)
602718a 
Make the now-obsolete "portable GObject Introspection reactor" an alias for the more standard ones.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#11738 portable gi obsolete twisted/twisted
1 participant
@exarkun